Re: [PATCH] src: consolidate XML/JSON exportation for rule

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Sun, Feb 12, 2017 at 02:48:43PM +0100, Pablo Neira Ayuso wrote:
> On Wed, Feb 08, 2017 at 09:12:53PM +0530, Shivani Bhardwaj wrote:
> > This completes the XML/JSON exportation using the new buffer class for
> > rule.
> 
> Applied, thanks Shivani.

Hm, there's some problem here, look:

drule.c: In function 'nftnl_rule_export':
rule.c:677:27: warning: passing argument 3 of 'vsnprintf' makes pointer from integer without a cast
   vsnprintf(b.buf, b.len, flags, expr);
                           ^
In file included from ../include/utils.h:4:0,
                 from ../include/internal.h:7,
                 from rule.c:11:
/usr/include/stdio.h:390:12: note: expected 'const char *
__restrict__' but argument is of type 'uint32_t'  extern int vsnprintf (char *__restrict __s, size_t __maxlen,
            ^
rule.c:677:34: warning: passing argument 4 of 'vsnprintf' from incompatible pointer type   vsnprintf(b.buf, b.len, flags, expr);
   vsnprintf(b.buf, b.len, flags, expr);
                                  ^
In file included from ../include/utils.h:4:0,
                 from ../include/internal.h:7,
                 from rule.c:11:
/usr/include/stdio.h:390:12: note: expected 'struct __va_list_tag *' but argument is of type 'struct nftnl_expr *'
 extern int vsnprintf (char *__restrict __s, size_t __maxlen,
            ^