Re: [PATCH v2 0/4] dtc unit-address and character set checks

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1689 bytes --]

On Fri, Feb 10, 2017 at 10:47:13AM -0600, Rob Herring wrote:
> This is a series of checks designed to check problems commonly found in
> binding reviews. The first 2 patches implement a stricter character set
> for property and node names. The 3rd patch checks unit address formatting.
> The 4th patch adds checks for PCI buses including more specific checks on
> unit address formatting.
> 
> In patches 1 and 2, I've turned the checks off by default. In patch 3,
> the leading '0x' or 0s check was moved to its own check. In patch 4, most
> of the bus struct was removed with only the type and the checks are called
> directly.

I'm still a touch uncomfortable about the tests in 1 & 2, but since
they're off by default, I've merged them.

3 & 4 have further comments.

> 
> Rob
> 
> 
> Rob Herring (4):
>   checks: Add Warning for stricter property name character checking
>   checks: Add Warning for stricter node name character checking
>   checks: Warn on node name unit-addresses with '0x' or leading 0s
>   checks: Add bus checks for PCI buses
> 
>  checks.c                       | 151 +++++++++++++++++++++++++++++++++++++++++
>  dtc.h                          |   7 ++
>  tests/run_tests.sh             |   2 +
>  tests/unit-addr-leading-0s.dts |  10 +++
>  tests/unit-addr-leading-0x.dts |  10 +++
>  5 files changed, 180 insertions(+)
>  create mode 100644 tests/unit-addr-leading-0s.dts
>  create mode 100644 tests/unit-addr-leading-0x.dts
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]