From: Nicholas Mc Guire <der.herr@hofr.at>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Marek Vasut <marek.vasut@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH] spi-nor: use ERR_CAST in return
Date: Mon, 13 Feb 2017 07:59:52 +0000 [thread overview]
Message-ID: <20170213075952.GD23235@osadl.at> (raw)
In-Reply-To: <20170213085311.227d6398@bbrezillon>
On Mon, Feb 13, 2017 at 08:53:11AM +0100, Boris Brezillon wrote:
> On Mon, 13 Feb 2017 07:35:52 +0000
> Nicholas Mc Guire <der.herr@hofr.at> wrote:
>
> > On Sun, Feb 12, 2017 at 11:04:10PM +0100, Boris Brezillon wrote:
> > > +Mika
> > >
> > > On Sun, 12 Feb 2017 22:45:43 +0100
> > > Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> > >
> > > > On Sun, 12 Feb 2017 17:43:43 +0100
> > > > Nicholas Mc Guire <der.herr@hofr.at> wrote:
> > > >
> > > > > This fixes a sparse warning about
> > > >
> > > > Your commit message seems to be incomplete.
> > >
> > > And here too, please change the prefix to "mtd: spi-nor: intel: ".
> > >
> >
> > What Im doing for checking prefix is:
> > hofrat@debian:~/git/linux-next$ git log --oneline drivers/mtd/spi-nor/intel-spi.c
> > 8afda8b spi-nor: Add support for Intel SPI serial flash controller
> >
> > is the method of checking the commit prefix with git log --oneline inapropriate ?
>
> It's appropriate, except in this case. You're referring to the commit
> introducing a new driver, so this is expected to not find the
> 'intel:' suffix, but you have 'Add support for Intel SPI serial flash
> controller' to clarify the scope.
>
> Regarding the "mtd: " prefix, I think it's better to have it, but
> apparently Cyrille is not enforcing that.
>
> > How would I have found the "mtd: spi-nor: intel:" in this case ?
>
> Well, it's a mix of common sense and 'git log --oneline' use :-). Here
> you're only modifying the intel driver, but nothing in your subject
> mentions it.
got it (maybe) - thanks!
hofrat
prev parent reply other threads:[~2017-02-13 8:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 16:43 [PATCH] spi-nor: use ERR_CAST in return Nicholas Mc Guire
2017-02-12 21:45 ` Boris Brezillon
2017-02-12 22:04 ` Boris Brezillon
2017-02-13 7:35 ` Nicholas Mc Guire
2017-02-13 7:53 ` Boris Brezillon
2017-02-13 7:59 ` Nicholas Mc Guire [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213075952.GD23235@osadl.at \
--to=der.herr@hofr.at \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.