Re: [PATCH] USB: serial: ftdi_sio: add device ID for Microsemi/Arrow SF2PLUS Dev Kit

[Johan Hovold <johan@kernel.org>]

[+CC: linux-usb]

Always make sure to CC linux-usb for USB patches.

On Fri, Feb 10, 2017 at 05:16:12PM +0100, Marek Vasut wrote:
> This development kit has an FT4232 on it with a custom USB VID/PID.
> The FT4232 provides four UARTs, but only two are used. The UART 0
> is used by the FlashPro5 programmer and UART 2 is connected to the
> SmartFusion2 CortexM3 SoC UART port.

Don't you want to use the "jtag" quirk for this one then to prevent the
driver from binding to interface 0? Or do you still need this interface
to be accessible as a tty device?

> Note that the USB VID is registered to Actel according to Linux USB
> VID database, but that was acquired by Microsemi.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: stable <stable@vger.kernel.org>
> Cc: Johan Hovold <johan@kernel.org>
> ---
>  drivers/usb/serial/ftdi_sio.c     |  1 +
>  drivers/usb/serial/ftdi_sio_ids.h | 10 ++++++++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index c98cf10be5af..14f0fb34f655 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -873,6 +873,7 @@ static const struct usb_device_id id_table_combined[] = {
>  	{ USB_DEVICE_AND_INTERFACE_INFO(MICROCHIP_VID, MICROCHIP_USB_BOARD_PID,
>  					USB_CLASS_VENDOR_SPEC,
>  					USB_SUBCLASS_VENDOR_SPEC, 0x00) },
> +	{ USB_DEVICE(ACTEL_VID, MICROSEMI_ARROW_SF2PLUS_BOARD_PID) },
>  	{ USB_DEVICE(JETI_VID, JETI_SPC1201_PID) },
>  	{ USB_DEVICE(MARVELL_VID, MARVELL_SHEEVAPLUG_PID),
>  		.driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> index 168ccb03ce08..a9d538d18344 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -627,6 +627,16 @@
>  #define MICROCHIP_USB_BOARD_PID	0x000A /* CDC RS-232 Emulation Demo */
>  
>  /*
> + * Microsemi/Arrow SF2PLUS Dev Kit
> + *
> + * This board has an FT4232 on it which provides four UART ports.
> + * UART 0 is used by the FlashPro5 programmer, UART 2 is connected
> + * to the UART of an CortexM3 SoC-FPGA on the board.
> + */
> +#define ACTEL_VID				0x1514
> +#define MICROSEMI_ARROW_SF2PLUS_BOARD_PID	0x2008
> +

Please place this before the Olimex section to try to maintain some
order based on VID.

> +/*
>   * RATOC REX-USB60F
>   */
>  #define RATOC_VENDOR_ID		0x0584

Thanks,
Johan