From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>,
linux-renesas-soc@vger.kernel.org, geert@linux-m68k.org,
magnus.damm@gmail.com
Subject: Re: [PATCH v2 3/4] arm64: renesas: r8a7796 dtsi: Add all HSCIF nodes
Date: Mon, 13 Feb 2017 14:03:39 +0100 [thread overview]
Message-ID: <20170213130339.GD29718@verge.net.au> (raw)
In-Reply-To: <28166972-c0fe-00f8-5d3e-0e482dfc06f7@cogentembedded.com>
On Mon, Feb 13, 2017 at 03:06:21PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 2/13/2017 3:01 PM, Simon Horman wrote:
>
> >>>Add the device nodes for all HSCIF serial ports, incl. clocks, and
> >>>clock domain.
> >>
> >> Not power domain?
> >>
> >>>Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> >>>Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >>>---
> >>>arch/arm64/boot/dts/renesas/r8a7796.dtsi | 70 ++++++++++++++++++++++++++++++++
> >>>1 file changed, 70 insertions(+)
> >>>
> >>>diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> >>>index 7bf0f2f..c508e0f 100644
> >>>--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> >>>+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> >>>@@ -421,6 +421,76 @@
> >>> };
> >>> };
> >>>
> >>>+ hscif0: serial@e6540000 {
> >>>+ compatible = "renesas,hscif-r8a7796",
> >>>+ "renesas,rcar-gen3-hscif",
> >>>+ "renesas,hscif";
> >>>+ reg = <0 0xe6540000 0 96>;
> >>
> >> 0xc0?
> >
> >Do you mean 96 should be 0xc0 (= 192 = 2 * 96) ?
>
> Oops! 0x60, of course.
Thanks,
I queued up this patch after
- s/clock domain/power domain/ in changelog
- Updating to use 0x60 as you suggest above.
> >If so, perhaps the r8a7795 needs updating too?
Thanks, I'll see about sending an update.
next prev parent reply other threads:[~2017-02-13 13:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 16:44 [PATCH v2 0/4] r8a7796 HSCIF integration Ulrich Hecht
2016-12-07 16:44 ` [PATCH v2 1/4] clk: shmobile: r8a7796: Add HSCIF clocks Ulrich Hecht
2016-12-09 8:59 ` Geert Uytterhoeven
2016-12-07 16:44 ` [PATCH v2 2/4] pinctrl: sh-pfc: r8a7796: Add HSCIF pins, groups, and functions Ulrich Hecht
2016-12-09 9:56 ` Geert Uytterhoeven
2016-12-13 9:40 ` Geert Uytterhoeven
2016-12-07 16:44 ` [PATCH v2 3/4] arm64: renesas: r8a7796 dtsi: Add all HSCIF nodes Ulrich Hecht
2016-12-08 9:09 ` Sergei Shtylyov
2017-02-13 12:01 ` Simon Horman
2017-02-13 12:06 ` Sergei Shtylyov
2017-02-13 13:03 ` Simon Horman [this message]
2016-12-07 16:44 ` [PATCH v2 4/4] arm64: renesas: r8a7796: Enable HSCIF DMA Ulrich Hecht
2016-12-09 9:58 ` Geert Uytterhoeven
2017-03-02 15:05 ` Simon Horman
2016-12-08 13:36 ` [PATCH v2 0/4] r8a7796 HSCIF integration Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213130339.GD29718@verge.net.au \
--to=horms@verge.net.au \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ulrich.hecht+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.