From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm: ensure atomic messages consistently include the name of the component Date: Mon, 13 Feb 2017 14:19:09 +0100 Message-ID: <20170213131909.GA32184@ulmo.ba.sec> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2113237849==" Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 947EA6E3D6 for ; Mon, 13 Feb 2017 13:19:12 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id c85so19471221wmi.1 for ; Mon, 13 Feb 2017 05:19:12 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2113237849== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="X1bOJ3K7DJ5YkBrT" Content-Disposition: inline --X1bOJ3K7DJ5YkBrT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 13, 2017 at 12:27:03PM +0000, Russell King wrote: > Most DRM messages include three pieces of information: the type of the > component (CRTC, ENCODER, CONNECTOR etc), the DRM object ID of the > component, and the component name. However, there are some messages > which omit the last piece of identifying information. This makes it > harder to debug failures when these messages are printed, because the > DRM object ID doesn't supply enough information to know which piece of > hardware had a problem. >=20 > Update the atomic modeset code to always print the component name along > with the type and DRM object ID. >=20 > Fixes: 4cba68507cf5 ("drm/atomic-helper: Reject legacy flips on a disable= d pipe") > Fixes: 8d4d0d700dda ("drm/atomic-helper: Print an error if vblank wait ti= mes out") > Fixes: 5481c8fb1da2 ("drm/atomic-helper: Check encoder/crtc constraints") > Fixes: 99cf4a29fa24 ("drm/atomic: Add current-mode blob to CRTC state") > Fixes: cc4ceb484b37 ("drm: Global atomic state handling") > Signed-off-by: Russell King > --- > drivers/gpu/drm/drm_atomic.c | 9 +++++---- > drivers/gpu/drm/drm_atomic_helper.c | 12 +++++++----- > 2 files changed, 12 insertions(+), 9 deletions(-) Looks good: Acked-by: Thierry Reding --X1bOJ3K7DJ5YkBrT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlihskkACgkQ3SOs138+ s6FvMg//bza0LSdF5VKoZEohO0EsW8Cn8vznUyycLGSjWlmklBflKL3onfcTMEiq FOaSTkJOong149kBmcXZJYhrXOf6wBN6svC6aS/i1pvstrQXbxZLFjztCUmS7Pmt WE0GxP3zqbO81W631rLZvZkfQbtSUYSLGWbnZWDiRsIzmYTlvI5UV7SQZaNRWGfy GmgvwKGNb47nS6CJyzxs0stpzewXn282uRQkPywBUb7XQXd/29VATv6dwRGV3y8r /WYMPcgUK1BIZLWC7fRzfpqQbV1nihOrnGUtLCyRxjSp9+05tSHXdJW8TILvkepa /rzo4ke3fqSVeniS7x8dUB0gJgEGLbg2Jdr9sGYQ2ONuLdLQnGUILrsq5OiaTKhR hGnaYAMb979Ox/5TCCNfBKrAzhBdeJnx6UqkwBOxcpKcXyFDWC9+Fxw/D8q2C4ic Cc1LIhecz4EqFOB6whCMa3up9b0grvb3w7lQBpbtZ8ZWJCBQdeJ9mHOHBFueOExg EpOje+7/3O4ogTG0ueyrlQRa8RtY5gwnrQWRXXIZxQq1CdBmB47wvuZNzWWW9512 4kP8LhZWCZfvU/B7iP8jUMGL/zk3dSpuZeEVNliweORanaYOdiVAHwTezPdB4/4+ Q8HyyM96IeDcuXkAASHLIRv0N4dVlYkuhXFSWzxLvyNxLPHhISw= =tgC0 -----END PGP SIGNATURE----- --X1bOJ3K7DJ5YkBrT-- --===============2113237849== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============2113237849==--