From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>,
dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
John McNamara <john.mcnamara@intel.com>,
Ben Walker <benjamin.walker@intel.com>
Subject: Re: [PATCH] doc: announce API/ABI changes for vhost
Date: Tue, 14 Feb 2017 08:51:05 +0530 [thread overview]
Message-ID: <20170214032105.GC3131@localhost.localdomain> (raw)
In-Reply-To: <11273851.Pnx70jxc9N@xps13>
On Mon, Feb 13, 2017 at 07:02:56PM +0100, Thomas Monjalon wrote:
> 2017-01-23 21:04, Yuanhan Liu:
> > I made a vhost ABI/API refactoring at v16.04, meant to avoid such issue
> > forever. Well, apparently, I lied.
> >
> > People are looking for more vhost-user options now days, other than
> > vhost-user net only. For example, SPDK (Storage Performance Development
> > Kit) are looking for chance of vhost-user SCSI and vhost-user block.
> >
> > Apparently, they also need a vhost-user backend, while DPDK already
> > has a (mature enough) backend, they don't want to implement it again
> > from scratch. They want to leverage the one DPDK provides.
> >
> > However, the last refactoring hasn't done that right, at least it's
> > not friendly for extending vhost-user to add more devices support.
> > For example, different virtio devices has its own feature set, while
> > APIs like rte_vhost_feature_disable(feature_mask) have no option to
> > tell the device type. Thus, a more proper API should look like:
> >
> > rte_vhost_feature_disable(device_type, feature_mask);
> >
> > Besides that, few public files and structures should be renamed, to
> > not let it bind to virtio-net. Specifically, they are:
> >
> > - virtio_net_device_ops --> vhost_device_ops
> > - rte_virtio_net.h --> rte_vhost.h
> >
> > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
next prev parent reply other threads:[~2017-02-14 3:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 13:04 [PATCH] doc: announce API/ABI changes for vhost Yuanhan Liu
2017-02-13 18:02 ` Thomas Monjalon
2017-02-14 3:21 ` Jerin Jacob [this message]
2017-02-14 13:54 ` Maxime Coquelin
2017-02-14 20:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214032105.GC3131@localhost.localdomain \
--to=jerin.jacob@caviumnetworks.com \
--cc=benjamin.walker@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.