From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Emmanuel Roullit <emmanuel.roullit@gmail.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Kumar Sanghvi <kumaras@chelsio.com>,
Nirranjan Kirubaharan <nirranjan@chelsio.com>,
stable@dpdk.org
Subject: Re: [PATCH 2/3] net/cxgbe: remove unused variable usage
Date: Tue, 14 Feb 2017 14:10:24 +0800 [thread overview]
Message-ID: <20170214061024.GS20916@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <8812ea01-9e01-217c-6440-adc3360e6c75@intel.com>
On Thu, Jan 26, 2017 at 11:05:22AM +0000, Ferruh Yigit wrote:
> On 1/26/2017 4:41 AM, Rahul Lakkireddy wrote:
> > On Wednesday, January 01/25/17, 2017 at 17:43:57 +0530, Ferruh Yigit wrote:
> >> On 1/24/2017 8:48 PM, Emmanuel Roullit wrote:
> >>> Found with clang static analysis:
> >>> drivers/net/cxgbe/sge.c:900:3: warning:
> >>> Value stored to 'in_use' is never read
> >>> in_use += q->size;
> >>> ^ ~~~~~~~
> >>>
> >>> Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API")
> >
> > This fixes line seems to be wrong. Should be:
> >
>
> >
> >>>
> >>> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
>
> > Fixes: 4a01078b4fd1 ("cxgbe: add Tx support")
> Cc: stable@dpdk.org
I doubt the necessary of picking it to a stable release: it doesn't fix
a real bug after all. Therefore, I will drop it for v16.11.1.
--yliu
>
> Acked-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
>
>
> Applied to dpdk-next-net/master, thanks.
>
> (patch 2/3 and 3/3 merged)
next prev parent reply other threads:[~2017-02-14 6:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 20:48 [PATCH 1/3] net/cxgbe: init data value before reading seeprom Emmanuel Roullit
2017-01-24 20:48 ` [PATCH 2/3] net/cxgbe: remove unused variable usage Emmanuel Roullit
2017-01-25 12:13 ` Ferruh Yigit
2017-01-26 4:41 ` Rahul Lakkireddy
2017-01-26 11:05 ` Ferruh Yigit
2017-02-14 6:10 ` Yuanhan Liu [this message]
2017-01-24 20:48 ` [PATCH 3/3] net/cxgbe: remove unused variable Emmanuel Roullit
2017-01-25 12:15 ` Ferruh Yigit
2017-01-25 12:12 ` [PATCH 1/3] net/cxgbe: init data value before reading seeprom Ferruh Yigit
2017-01-26 11:06 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214061024.GS20916@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=emmanuel.roullit@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=kumaras@chelsio.com \
--cc=nirranjan@chelsio.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.