From: Richard Cochran <richardcochran@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ptp: use is_visible method to hide unused attributes
Date: Tue, 14 Feb 2017 09:42:26 +0100 [thread overview]
Message-ID: <20170214084226.GC8048@localhost.localdomain> (raw)
In-Reply-To: <20170214035108.19622-3-dmitry.torokhov@gmail.com>
On Mon, Feb 13, 2017 at 07:51:07PM -0800, Dmitry Torokhov wrote:
> Instead of creating selected attributes after the device is created (and
> after userspace potentially seen uevent), lets use attribute group
> is_visible() method to control which attributes are shown. This will allow
> us to create all attributes (except "pins" group, which will be taken care
> of later) before userspace gets notified about new ptp class device.
At first glance, this patch and the next look like nice improvements.
I don't futz around with sysfs code very often, and so may I ask how
or whether you tested it?
Thanks,
Richard
next prev parent reply other threads:[~2017-02-14 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 3:51 [PATCH 1/4] ptp: do not explicitly set drvdata in ptp_clock_register() Dmitry Torokhov
2017-02-14 3:51 ` [PATCH 2/4] ptp: use kcalloc/kmallco_array when allocating arrays Dmitry Torokhov
2017-02-14 8:38 ` Richard Cochran
2017-02-14 3:51 ` [PATCH 3/4] ptp: use is_visible method to hide unused attributes Dmitry Torokhov
2017-02-14 8:42 ` Richard Cochran [this message]
2017-02-14 18:07 ` Dmitry Torokhov
2017-02-14 18:13 ` Richard Cochran
2017-02-14 3:51 ` [PATCH 4/4] ptp: create "pins" together with the rest of attributes Dmitry Torokhov
2017-02-14 8:30 ` [PATCH 1/4] ptp: do not explicitly set drvdata in ptp_clock_register() Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214084226.GC8048@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.