From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] kmscube: Add new package
Date: Tue, 14 Feb 2017 09:18:03 +0100 [thread overview]
Message-ID: <20170214091803.70ab8d9a@free-electrons.com> (raw)
In-Reply-To: <CAOMZO5Dwdu5-+bV=TXA6=-wg+=W05BhE1eEYhzZk6zV71MUBdA@mail.gmail.com>
Hello,
On Mon, 13 Feb 2017 20:03:29 -0200, Fabio Estevam wrote:
> > PKG_CHECK_MODULES(EGL, egl)
> > PKG_CHECK_MODULES(GLES2, glesv2)
This code means that kmscube will only build fine if the pkg-config
files egl.pc and glesv2.pc are available.
> checking for DRM... yes
> checking for GBM... yes
> checking for EGL... yes
> checking for GLES2... yes
>
> BR2_PACKAGE_MESA3D_OPENGL_EGL is selected by the Etnaviv mesa driver:
> BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV, which comes from a patch I
> sent today.
>
> I don't have BR2_PACKAGE_MESA3D_OPENGL_ES option selected, but I do
> get "checking for GLES2... yes", so I am bit confused.
>
> Is your suggestion to do something like this?
>
> config BR2_PACKAGE_KMSCUBE
> bool "kmscube"
> depends on BR2_PACKAGE_MESA3D && BR2_PACKAGE_LIBDRM
> depends on BR2_PACKAGE_MESA3D_OPENGL_EGL
> select BR2_PACKAGE_MESA3D_OPENGL_ES
I would do just:
depends on BR2_PACKAGE_MESA3D_OPENGL_EGL
depends on BR2_PACKAGE_MESA3D_OPENGL_ES
that is sufficient, and it's what glmark2/Config.in is doing (except
glmark2 is a bit more complicated since it also supports full OpenGL,
not only OpenGL ES).
The "depends on BR2_PACKAGE_MESA3D && BR2_PACKAGE_LIBDRM" are useless,
because if BR2_PACKAGE_MESA3D_OPENGL_EGL and
BR2_PACKAGE_MESA3D_OPENGL_ES are enabled, then surely mesa3d is
enabled. And mesa3d selects libdrm, so we're good.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-14 8:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 18:49 [Buildroot] [PATCH v2] kmscube: Add new package Fabio Estevam
2017-02-13 20:34 ` Gary Bisson
2017-02-13 21:31 ` Thomas Petazzoni
2017-02-13 22:03 ` Fabio Estevam
2017-02-13 23:43 ` Fabio Estevam
2017-02-14 8:18 ` Thomas Petazzoni [this message]
2017-02-14 9:24 ` Maxime Ripard
2017-02-14 10:23 ` Thomas Petazzoni
2017-02-15 8:55 ` Maxime Ripard
2017-02-15 9:04 ` Thomas Petazzoni
2017-02-14 12:30 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214091803.70ab8d9a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.