From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Chris Metcalf <cmetcalf@mellanox.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
linux-next@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] tile: fix build failure
Date: Tue, 14 Feb 2017 10:01:57 +1100 [thread overview]
Message-ID: <20170214100157.1740cdee@canb.auug.org.au> (raw)
In-Reply-To: <58A23A20.30000@gmail.com>
Hi Sudip,
On Mon, 13 Feb 2017 22:58:40 +0000 Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
>
> On Tuesday 24 January 2017 04:56 PM, Chris Metcalf wrote:
> > On 1/24/2017 11:39 AM, Sudip Mukherjee wrote:
> >> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> >>
> >> The build of tilegx allmodconfig was failing with errors like:
> >> ../arch/tile/include/asm/div64.h:5:15: error: unknown type name 'u64'
> >> static inline u64 mul_u32_u32(u32 a, u32 b)
> >> ^~~
> >> ../arch/tile/include/asm/div64.h:5:31: error: unknown type name 'u32'
> >> static inline u64 mul_u32_u32(u32 a, u32 b)
> >> ^~~
> >> ../arch/tile/include/asm/div64.h:5:38: error: unknown type name 'u32'
> >> static inline u64 mul_u32_u32(u32 a, u32 b)
> >> ^~~
> >> In file included from ../fs/ubifs/ubifs.h:26:0,
> >> from ../fs/ubifs/shrinker.c:42:
> >> ../include/linux/math64.h: In function 'mul_u64_u32_shr':
> >> ../arch/tile/include/asm/div64.h:9:21: error: implicit declaration of
> >> function 'mul_u32_u32' [-Werror=implicit-function-declaration]
> >>
> >> The simplest solution was to include the types header file.
> >>
> >> Fixes: 9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and
> >> friends")
> >> Cc: Peter Zijlstra <peterz@infradead.org>
> >> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> >> ---
> >>
> >> build log is at:
> >> https://travis-ci.org/sudipm-mukherjee/parport/jobs/194717687
> >>
> >> arch/tile/include/asm/div64.h | 1 +
> >> 1 file changed, 1 insertion(+)
> >
> > Acked-by: Chris Metcalf <cmetcalf@mellanox.com>
> >
>
> linux-next is still failing for this error. Who will pick this up?
Presumably the tip tree (timers/core). Added Thomas to cc.
--
Cheers,
Stephen Rothwell
next prev parent reply other threads:[~2017-02-13 23:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 16:39 [PATCH] tile: fix build failure Sudip Mukherjee
2017-01-24 16:56 ` Chris Metcalf
2017-02-13 22:58 ` Sudip Mukherjee
2017-02-13 23:01 ` Stephen Rothwell [this message]
2017-02-14 8:48 ` Thomas Gleixner
2017-02-14 8:43 ` [tip:timers/core] math64, tile: Fix " tip-bot for Sudip Mukherjee
-- strict thread matches above, loose matches on Subject: below --
2015-09-07 14:36 [PATCH] tile: fix " Sudip Mukherjee
2015-09-08 17:44 ` Chris Metcalf
2015-09-28 6:46 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214100157.1740cdee@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=cmetcalf@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.