From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/7] btrfs: ulist: make the finalization function public
Date: Tue, 14 Feb 2017 12:44:48 +0100 [thread overview]
Message-ID: <20170214114448.GL16928@suse.cz> (raw)
In-Reply-To: <50638123-8b6a-c102-47f4-57a176cca873@cn.fujitsu.com>
On Tue, Feb 14, 2017 at 05:29:14PM +0800, Qu Wenruo wrote:
>
>
> At 02/13/2017 10:30 PM, David Sterba wrote:
> > Make ulist_fini externally visible so the ulist API is complete.
>
> Looks good to me.
>
> While I'm not pretty sure if the name "ulist_fini" is good enough.
>
> Maybe "ulist_finish" or "ulist_release" (just like release_path and
> free_path)?
Yeah, I don't like the name either, ulist_release sounds ok to me.
next prev parent reply other threads:[~2017-02-14 11:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 14:30 [PATCH 0/7] Qgroup cleanups David Sterba
2017-02-13 14:30 ` [PATCH 1/7] btrfs: qgroups: make __del_qgroup_relation static David Sterba
2017-02-13 14:30 ` [PATCH 2/7] btrfs: ulist: make the finalization function public David Sterba
2017-02-14 9:29 ` Qu Wenruo
2017-02-14 11:44 ` David Sterba [this message]
2017-02-13 14:30 ` [PATCH 3/7] btrfs: embed extent_changeset::range_changed to the structure David Sterba
2017-02-14 9:23 ` Qu Wenruo
2017-02-13 14:30 ` [PATCH 4/7] btrfs: check quota status earlier and don't do unnecessary frees David Sterba
2017-02-13 14:30 ` [PATCH 5/7] btrfs: remove unnecessary mutex lock in qgroup_account_snapshot David Sterba
2017-02-13 14:30 ` [PATCH 6/7] btrfs: qgroups: opencode qgroup_free helper David Sterba
2017-02-13 14:30 ` [PATCH 7/7] btrfs: remove pointless rcu protection from btrfs_qgroup_inherit David Sterba
2017-02-15 15:51 ` [PATCH 8/7] btrfs: ulist: rename ulist_fini to ulist_release David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214114448.GL16928@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.