From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org,
Helmut Schaa <helmut.schaa@googlemail.com>
Subject: Re: [PATCH 02/10] rt2800: identify station based on status WCID
Date: Tue, 14 Feb 2017 14:32:45 +0100 [thread overview]
Message-ID: <20170214133244.GA6437@redhat.com> (raw)
In-Reply-To: <bf62370e-fe78-470b-4902-92fbb1d093f8@nbd.name>
On Tue, Feb 14, 2017 at 02:10:01PM +0100, Felix Fietkau wrote:
> On 2017-02-14 13:46, Stanislaw Gruszka wrote:
> > Add station field to skb_frame_desc and assign it according to status
> > WCID. This field will be used in the future.
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> I see some potential for race conditions in this approach. You store the
> sta pointer in struct skb_frame_desc, but I don't see anything that
> guarantees that the sta will be around for as long as the tx frame is held.
> I think a better approach would be to not store the sta pointer in
> skb_frame_desc at all.
> Instead, add a driver callback to look up the sta by wcid, and use rcu
> properly there. Make sure you only hold the sta pointer obtained from
> that call within a RCU read locked section.
On patch 7, where ->sta start to be used, I added RCU protection.
Stanislaw
next prev parent reply other threads:[~2017-02-14 13:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 12:45 [PATCH 00/10] rt2x00 patches 14.02.2017 Stanislaw Gruszka
2017-02-14 12:45 ` [PATCH 01/10] rt2x00: rt2800lib: move rt2800_drv_data declaration into rt2800lib.h Stanislaw Gruszka
2017-02-14 12:46 ` [PATCH 02/10] rt2800: identify station based on status WCID Stanislaw Gruszka
2017-02-14 13:10 ` Felix Fietkau
2017-02-14 13:32 ` Stanislaw Gruszka [this message]
2017-02-14 13:46 ` Felix Fietkau
2017-02-14 12:46 ` [PATCH 03/10] rt2x00: separte filling tx status from rt2x00lib_txdone Stanislaw Gruszka
2017-02-14 12:46 ` [PATCH 04/10] rt2x00: separte clearing entry " Stanislaw Gruszka
2017-02-14 12:46 ` [PATCH 05/10] rt2x00: add txdone nomatch function Stanislaw Gruszka
2017-02-14 12:46 ` [PATCH 06/10] rt2x00: fixup fill_tx_status for nomatch case Stanislaw Gruszka
2017-02-14 13:51 ` Felix Fietkau
2017-02-14 16:32 ` Kalle Valo
2017-02-14 12:46 ` [PATCH 07/10] rt2x00: use txdone_nomatch on rt2800usb Stanislaw Gruszka
2017-02-14 12:46 ` [PATCH 08/10] rt2800: status based rate flags for nomatch case Stanislaw Gruszka
2017-02-14 12:46 ` [PATCH 09/10] rt2800: use TXOP_BACKOFF for probe frames Stanislaw Gruszka
2017-02-14 12:46 ` [PATCH 10/10] rt2x00: fix rt2x00debug_dump_frame comment Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214133244.GA6437@redhat.com \
--to=sgruszka@redhat.com \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.