Re: [PATCH] Make it compiler under Xen 4.7.

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Mon, Feb 13, 2017 at 08:46:29AM +0000, Paul Durrant wrote:
> > -----Original Message-----
> > From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> > Sent: 10 February 2017 21:52
> > To: Paul Durrant <Paul.Durrant@citrix.com>; xen-devel@lists.xenproject.org
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Subject: [PATCH] Make it compiler under Xen 4.7.
> > 
> > With b7f76a699dcfadc0a52ab45b33cc72dbf3a69e7b
> > Author: Ian Campbell <ian.campbell@citrix.com>
> > Date:   Mon Jun 1 16:20:09 2015 +0100
> > 
> >     tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn.
> > 
> > commit 32486916793fd78a41fc25e53d2b53a5aa0b1bd5
> > Author: Ian Campbell <ian.campbell@citrix.com>
> > Date:   Thu Jun 18 16:30:19 2015 +0100
> > 
> >     tools: Refactor foreign memory mapping into libxenforeignmemory
> > 
> > We need to use the compat layer.
> > 
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> Thanks for taking the time to send this. I'll incorporate this a.s.a.p.

Thank you. Keep in mind that it will likely break against
older Xen versions (Xen 4.4?) as there is no xenctrl_compat.h

[Oh wait, Xen 4.4 didn't have ioreq either, so perhaps Xen 4.5?]

But I wasn't sure how you wanted to deal with this being compiled
against say Xen 4.6?

Or maybe the README file should just say what version of Xen
is required? (I can send an patch for that too if you would like).

> 
> Acked-by: Paul Durrant <paul.durrant@citrix.com>
> 
> > 
> > ---
> > CC: paul.durrant@citrix.com
> > 
> > v1: First version
> > ---
> >  demu.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/demu.c b/demu.c
> > index 2933efb..7d73a69 100644
> > --- a/demu.c
> > +++ b/demu.c
> > @@ -56,7 +56,12 @@
> > 
> >  #include <locale.h>
> > 
> > +#define XC_WANT_COMPAT_MAP_FOREIGN_API 1
> > +#define XC_WANT_COMPAT_EVTCHN_API 1
> > +
> >  #include <xenctrl.h>
> > +#include <xenctrl_compat.h>
> > +
> >  #include <xen/hvm/ioreq.h>
> > 
> >  #include "debug.h"
> > @@ -126,7 +131,7 @@ typedef enum {
> >  typedef struct demu_state {
> >      demu_seq_t          seq;
> >      xc_interface        *xch;
> > -    xc_interface        *xceh;
> > +    xc_evtchn          *xceh;
> >      domid_t             domid;
> >      unsigned int        vcpus;
> >      ioservid_t          ioservid;
> > --
> > 2.9.3
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel