From: Jiri Olsa <jolsa@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
peterz@infradead.org, joro@8bytes.org, mingo@redhat.com
Subject: Re: [PATCH v9 0/8] perf/amd/iommu: Enable multi-IOMMU support
Date: Wed, 15 Feb 2017 11:44:24 +0100 [thread overview]
Message-ID: <20170215104424.GA8207@krava> (raw)
In-Reply-To: <20170215101323.ecggpvbkbcqaq5xs@pd.tnic>
On Wed, Feb 15, 2017 at 11:13:23AM +0100, Borislav Petkov wrote:
> On Tue, Feb 07, 2017 at 02:40:28AM -0600, Suravee Suthikulpanit wrote:
> > From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> >
> > This patch series modifies the existing IOMMU and Perf drivers to support
> > systems with multiple IOMMUs by allocating an amd_iommu PMU per IOMMU instance.
> > This allows users to specify performance events and filters separately for each
> > IOMMU.
> >
> > This has been tested on the new family17h-based server w/ multiple IOMMUs.
>
> Ok, so far so good.
>
> There's just one thing:
>
> $ perf stat -e amd_iommu_X/Y
>
> says <not supported> and only doing the system wide tracing with -a does
> it count events.
does it say unsupported when you omit -a? it should display error
and options like:
[jolsa@krava perf]$ ./perf stat -e 'cpu/cpu-cycles/'
Usage: perf stat [<options>] [<command>]
-a, --all-cpus system-wide collection from all CPUs
-A, --no-aggr disable CPU count aggregation
-B, --big-num print large numbers with thousands' separators
-C, --cpu <cpu> list of cpus to monitor in system-wide
...
>
> So, lemme ask perf tool people, can we guys make the -a thing default
> when detect that we're running only uncore events which all should need
> -a anyway?
it's possible, can't think of anything being hurt by this now..
jirka
next prev parent reply other threads:[~2017-02-15 10:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 8:40 [PATCH v9 0/8] perf/amd/iommu: Enable multi-IOMMU support Suravee Suthikulpanit
2017-02-07 8:40 ` Suravee Suthikulpanit
[not found] ` <1486456836-17428-1-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2017-02-07 8:40 ` [PATCH v9 1/8] perf/amd/iommu: Declare pr_fmt and remove unnecessary pr_debug Suravee Suthikulpanit
2017-02-07 8:40 ` Suravee Suthikulpanit
2017-02-07 8:40 ` [PATCH v9 2/8] perf/amd/iommu: Clean up bitwise operations Suravee Suthikulpanit
2017-02-07 8:40 ` Suravee Suthikulpanit
2017-02-07 8:40 ` [PATCH v9 3/8] perf/amd/iommu: Clean up perf_iommu_read() Suravee Suthikulpanit
2017-02-07 8:40 ` Suravee Suthikulpanit
2017-02-07 8:40 ` [PATCH v9 4/8] iommu/amd: Introduce amd_iommu_get_num_iommus() Suravee Suthikulpanit
2017-02-07 8:40 ` Suravee Suthikulpanit
2017-02-07 8:40 ` [PATCH v9 5/8] perf/amd/iommu: Modify functions to query max banks and counters Suravee Suthikulpanit
2017-02-07 8:40 ` Suravee Suthikulpanit
[not found] ` <1486456836-17428-6-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2017-02-08 19:31 ` Borislav Petkov
2017-02-08 19:31 ` Borislav Petkov
2017-02-07 8:40 ` [PATCH v9 6/8] perf/amd/iommu: Modify amd_iommu_pc_get_set_reg_val() to allow specifying IOMMU Suravee Suthikulpanit
2017-02-07 8:40 ` Suravee Suthikulpanit
[not found] ` <1486456836-17428-7-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2017-02-08 19:32 ` Borislav Petkov
2017-02-08 19:32 ` Borislav Petkov
2017-02-07 8:40 ` [PATCH v9 7/8] perf/amd/iommu: Fix sysfs perf attribute groups Suravee Suthikulpanit
2017-02-07 8:40 ` Suravee Suthikulpanit
2017-02-07 8:40 ` [PATCH v9 8/8] perf/amd/iommu: Enable support for multiple IOMMUs Suravee Suthikulpanit
2017-02-07 8:40 ` Suravee Suthikulpanit
[not found] ` <1486456836-17428-9-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2017-02-08 19:33 ` Borislav Petkov
2017-02-08 19:33 ` Borislav Petkov
[not found] ` <20170208193340.x7lka54ismqqy7nw-fF5Pk5pvG8Y@public.gmane.org>
2017-02-15 7:13 ` Suravee Suthikulpanit
2017-02-15 7:13 ` Suravee Suthikulpanit
[not found] ` <483deec0-412f-bc34-de30-ce6ffcce3d4b-5C7GfCeVMHo@public.gmane.org>
2017-02-15 10:28 ` Borislav Petkov
2017-02-15 10:28 ` Borislav Petkov
2017-02-15 10:13 ` [PATCH v9 0/8] perf/amd/iommu: Enable multi-IOMMU support Borislav Petkov
2017-02-15 10:13 ` Borislav Petkov
2017-02-15 10:44 ` Jiri Olsa [this message]
2017-02-15 11:13 ` Borislav Petkov
2017-02-15 11:13 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215104424.GA8207@krava \
--to=jolsa@redhat.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=acme@kernel.org \
--cc=bp@alien8.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jolsa@kernel.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.