From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Hold forcewake for whole of punit communication Date: Wed, 15 Feb 2017 13:33:01 +0200 Message-ID: <20170215113301.GS31595@intel.com> References: <20170215104129.6271-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBE2D6E219 for ; Wed, 15 Feb 2017 11:33:04 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170215104129.6271-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBGZWIgMTUsIDIwMTcgYXQgMTA6NDE6MjlBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFRha2UgdGhlIGZvcmNld2FrZSBmb3IgcHVuaXQgYWNjZXNzIGFuZCBob2xkIGl0IGFj cm9zcyBvdXIgd2FpdHMgdG8KPiBlbnN1cmUgdGhhdCB0aGUgcG93ZXJ3ZWxsIGlzIG5vdCBkcm9w cGVkIGJ5IGEgc3B1cmlvdXMgc2xlZXAuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29u IDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3Vv cHBhbGFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zaWRl YmFuZC5jIHwgNTUgKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zaWRlYmFuZC5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfc2lkZWJhbmQuYwo+IGluZGV4IDlmNzgyYjVlYjZlNi4uY2U2ZDE2NmQ2 N2VhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3NpZGViYW5kLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zaWRlYmFuZC5jCj4gQEAgLTM5LDQy ICszOSw1NSBAQAo+ICAvKiBQcml2YXRlIHJlZ2lzdGVyIHdyaXRlLCBkb3VibGUtd29yZCBhZGRy ZXNzaW5nLCBub24tcG9zdGVkICovCj4gICNkZWZpbmUgU0JfQ1JXUkRBX05QCTB4MDcKPiAgCj4g LXN0YXRpYyBpbnQgdmx2X3NpZGViYW5kX3J3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiwgdTMyIGRldmZuLAo+IC0JCQkgICB1MzIgcG9ydCwgdTMyIG9wY29kZSwgdTMyIGFkZHIs IHUzMiAqdmFsKQo+ICtzdGF0aWMgaW50IHZsdl9zaWRlYmFuZF9ydyhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4gKwkJCSAgIHUzMiBkZXZmbiwgdTMyIHBvcnQsIHUzMiBvcGNv ZGUsIHUzMiBhZGRyLAo+ICsJCQkgICB1MzIgKnZhbCkKPiAgewo+IC0JdTMyIGNtZCwgYmUgPSAw eGYsIGJhciA9IDA7Cj4gLQlib29sIGlzX3JlYWQgPSAob3Bjb2RlID09IFNCX01SRF9OUCB8fCBv cGNvZGUgPT0gU0JfQ1JSRERBX05QKTsKPiArCWNvbnN0IGJvb2wgaXNfcmVhZCA9IChvcGNvZGUg PT0gU0JfTVJEX05QIHx8IG9wY29kZSA9PSBTQl9DUlJEREFfTlApOwo+ICsJZW51bSBmb3JjZXdh a2VfZG9tYWlucyBmd19kb21haW5zOwo+ICsJaW50IGVyciA9IDA7Cj4gIAo+IC0JY21kID0gKGRl dmZuIDw8IElPU0ZfREVWRk5fU0hJRlQpIHwgKG9wY29kZSA8PCBJT1NGX09QQ09ERV9TSElGVCkg fAo+IC0JCShwb3J0IDw8IElPU0ZfUE9SVF9TSElGVCkgfCAoYmUgPDwgSU9TRl9CWVRFX0VOQUJM RVNfU0hJRlQpIHwKPiAtCQkoYmFyIDw8IElPU0ZfQkFSX1NISUZUKTsKPiArCWxvY2tkZXBfYXNz ZXJ0X2hlbGQoJmRldl9wcml2LT5zYl9sb2NrKTsKPiAgCj4gLQlXQVJOX09OKCFtdXRleF9pc19s b2NrZWQoJmRldl9wcml2LT5zYl9sb2NrKSk7Cj4gKwlmd19kb21haW5zID0gaW50ZWxfdW5jb3Jl X2ZvcmNld2FrZV9mb3JfcmVnKGRldl9wcml2LAo+ICsJCQkJCQkgICAgVkxWX0lPU0ZfRE9PUkJF TExfUkVRLAoKVGhlIG1haWxib3ggbGl2ZXMgaW4gdGhlIGRpc3BsYXkgcmVnaXN0ZXIgcmFuZ2Us IGFuZCBzbyBkb2Vzbid0IG5lZWQKZm9yY2V3YWtlLgoKPiArCQkJCQkJICAgIEZXX1JFR19SRUFE IHwgRldfUkVHX1dSSVRFKTsKPiArCWludGVsX3VuY29yZV9mb3JjZXdha2VfZ2V0KGRldl9wcml2 LCBmd19kb21haW5zKTsKPiAgCj4gLQlpZiAoaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3By aXYsCj4gLQkJCQkgICAgVkxWX0lPU0ZfRE9PUkJFTExfUkVRLCBJT1NGX1NCX0JVU1ksIDAsCj4g LQkJCQkgICAgNSkpIHsKPiArCWlmIChpbnRlbF93YWl0X2Zvcl9yZWdpc3Rlcl9mdyhkZXZfcHJp diwKPiArCQkJCSAgICAgICBWTFZfSU9TRl9ET09SQkVMTF9SRVEsIElPU0ZfU0JfQlVTWSwgMCwK PiArCQkJCSAgICAgICA1KSkgewo+ICAJCURSTV9ERUJVR19EUklWRVIoIklPU0Ygc2lkZWJhbmQg aWRsZSB3YWl0ICglcykgdGltZWQgb3V0XG4iLAo+ICAJCQkJIGlzX3JlYWQgPyAicmVhZCIgOiAi d3JpdGUiKTsKPiAtCQlyZXR1cm4gLUVBR0FJTjsKPiArCQllcnIgPSAtRUFHQUlOOwo+ICsJCWdv dG8gb3V0Owo+ICAJfQo+ICAKPiAtCUk5MTVfV1JJVEUoVkxWX0lPU0ZfQUREUiwgYWRkcik7Cj4g LQlJOTE1X1dSSVRFKFZMVl9JT1NGX0RBVEEsIGlzX3JlYWQgPyAwIDogKnZhbCk7Cj4gLQlJOTE1 X1dSSVRFKFZMVl9JT1NGX0RPT1JCRUxMX1JFUSwgY21kKTsKPiArCUk5MTVfV1JJVEVfRlcoVkxW X0lPU0ZfQUREUiwgYWRkcik7Cj4gKwlJOTE1X1dSSVRFX0ZXKFZMVl9JT1NGX0RBVEEsIGlzX3Jl YWQgPyAwIDogKnZhbCk7Cj4gKwlJOTE1X1dSSVRFX0ZXKFZMVl9JT1NGX0RPT1JCRUxMX1JFUSwK PiArCQkgICAgICAoZGV2Zm4gPDwgSU9TRl9ERVZGTl9TSElGVCkgfAo+ICsJCSAgICAgIChvcGNv ZGUgPDwgSU9TRl9PUENPREVfU0hJRlQpIHwKPiArCQkgICAgICAocG9ydCA8PCBJT1NGX1BPUlRf U0hJRlQpIHwKPiArCQkgICAgICAoMHhmIDw8IElPU0ZfQllURV9FTkFCTEVTX1NISUZUKSB8Cj4g KwkJICAgICAgKDAgPDwgSU9TRl9CQVJfU0hJRlQpKTsKPiAgCj4gLQlpZiAoaW50ZWxfd2FpdF9m b3JfcmVnaXN0ZXIoZGV2X3ByaXYsCj4gLQkJCQkgICAgVkxWX0lPU0ZfRE9PUkJFTExfUkVRLCBJ T1NGX1NCX0JVU1ksIDAsCj4gLQkJCQkgICAgNSkpIHsKPiArCj4gKwlpZiAoaW50ZWxfd2FpdF9m b3JfcmVnaXN0ZXJfZncoZGV2X3ByaXYsCj4gKwkJCQkgICAgICAgVkxWX0lPU0ZfRE9PUkJFTExf UkVRLCBJT1NGX1NCX0JVU1ksIDAsCj4gKwkJCQkgICAgICAgNSkpIHsKPiAgCQlEUk1fREVCVUdf RFJJVkVSKCJJT1NGIHNpZGViYW5kIGZpbmlzaCB3YWl0ICglcykgdGltZWQgb3V0XG4iLAo+ICAJ CQkJIGlzX3JlYWQgPyAicmVhZCIgOiAid3JpdGUiKTsKPiAtCQlyZXR1cm4gLUVUSU1FRE9VVDsK PiArCQllcnIgPSAtRVRJTUVET1VUOwo+ICsJCWdvdG8gb3V0Owo+ICAJfQo+ICAKPiAgCWlmIChp c19yZWFkKQo+IC0JCSp2YWwgPSBJOTE1X1JFQUQoVkxWX0lPU0ZfREFUQSk7Cj4gKwkJKnZhbCA9 IEk5MTVfUkVBRF9GVyhWTFZfSU9TRl9EQVRBKTsKPiAgCj4gLQlyZXR1cm4gMDsKPiArb3V0Ogo+ ICsJaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9wdXQoZGV2X3ByaXYsIGZ3X2RvbWFpbnMpOwo+ICsJ cmV0dXJuIGVycjsKPiAgfQo+ICAKPiAgdTMyIHZsdl9wdW5pdF9yZWFkKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwgdTMyIGFkZHIpCj4gLS0gCj4gMi4xMS4wCj4gCj4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFp bGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUg U3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK