All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: tpmdd-devel@lists.sourceforge.net,
	linux-security-module@vger.kernel.org,
	Peter Huewe <peterhuewe@gmx.de>,
	Marcel Selhorst <tpmdd@selhorst.net>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: declare tpm2_get_pcr_allocation() as static
Date: Wed, 15 Feb 2017 11:56:43 -0700	[thread overview]
Message-ID: <20170215185643.GG19162@obsidianresearch.com> (raw)
In-Reply-To: <20170215180228.25650-1-jarkko.sakkinen@linux.intel.com>

On Wed, Feb 15, 2017 at 08:02:28PM +0200, Jarkko Sakkinen wrote:
> There's no need to export tpm2_get_pcr_alloation() because it is only
> a helper function for tpm2_auto_startup(). For the same reason it does
> not make much sense to maintain documentation for it.

Please stop moving these functions around, you are just breaking the
git history and git blame - there cosmetic reason of having a certain
order is not worth this damage.

Jason

  reply	other threads:[~2017-02-15 18:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15 18:02 [PATCH] tpm: declare tpm2_get_pcr_allocation() as static Jarkko Sakkinen
2017-02-15 18:02 ` Jarkko Sakkinen
2017-02-15 18:56 ` Jason Gunthorpe [this message]
2017-02-15 19:06   ` Jarkko Sakkinen
2017-02-17 10:24 ` Jarkko Sakkinen
2017-02-20 11:20   ` [tpmdd-devel] " Jarkko Sakkinen
     [not found]   ` <20170217102427.427h3qxwajocilji-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-02-21  5:50     ` Nayna
2017-02-21  5:50       ` Nayna
     [not found]       ` <58ABD542.1040704-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-02-21  6:17         ` Jarkko Sakkinen
2017-02-21  6:17           ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170215185643.GG19162@obsidianresearch.com \
    --to=jgunthorpe@obsidianresearch.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=tpmdd@selhorst.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.