From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: maomao xu <albert008.xu@gmail.com>,
devel@driverdev.osuosl.org, gregkh <gregkh@linuxfoundation.org>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rashika Kheria <rashika.kheria@gmail.com>,
singhalsimran0@gmail.com
Subject: Re: [PATCH] staging: rtl8192u: Fix warnings about endianness
Date: Wed, 15 Feb 2017 23:31:16 +0300 [thread overview]
Message-ID: <20170215203115.GC4108@mwanda> (raw)
In-Reply-To: <CAK8P3a3E9z0xhMp3jcyXvs-VvfM7ZBp5aUwLm1c=DXfKTYvxKg@mail.gmail.com>
On Wed, Feb 15, 2017 at 09:33:15AM +0100, Arnd Bergmann wrote:
> I see the same warning was addressed very differently in 99277c1f9962
> ("Staging: rtl8192e: Fix Sparse warning of cast to restricted __le16 in
> rtllib_crypt_tkip.c"), which was for a close relative of that driver.
>
> Only one of the two approaches (at most) can be correct, so we
> regardless of your patch either rtl8192e or rtl8192u is broken on
> big-endian machines.
99277c1f9962 ("Staging: rtl8192e: Fix Sparse warning of cast to restricted __le16 in
rtllib_crypt_tkip.c") is obviously broken. Can you send a patch to
change it back?
regards,
dan carpenter
next prev parent reply other threads:[~2017-02-15 20:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 7:54 [PATCH] staging: rtl8192u: Fix warnings about endianness maomao xu
2017-02-15 8:33 ` Arnd Bergmann
2017-02-15 20:31 ` Dan Carpenter [this message]
2017-02-18 3:55 ` maomao
-- strict thread matches above, loose matches on Subject: below --
2017-02-15 9:06 maomao xu
2017-02-15 9:44 ` kbuild test robot
2017-02-16 18:43 ` Greg KH
2017-02-15 10:21 maomao xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215203115.GC4108@mwanda \
--to=dan.carpenter@oracle.com \
--cc=albert008.xu@gmail.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=rashika.kheria@gmail.com \
--cc=singhalsimran0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.