From mboxrd@z Thu Jan 1 00:00:00 1970 From: chunyan.zhang@spreadtrum.com (Chunyan Zhang) Date: Thu, 16 Feb 2017 15:57:14 +0800 Subject: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G In-Reply-To: <20170214155743.GG23718@leverpostej> References: <1487063952-7113-1-git-send-email-chunyan.zhang@spreadtrum.com> <1487063952-7113-2-git-send-email-chunyan.zhang@spreadtrum.com> <20170214155743.GG23718@leverpostej> Message-ID: <20170216075713.GA8569@spreadtrum.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On ?, 2? 14, 2017 at 03:57:43?? +0000, Mark Rutland wrote: > Hi, > > On Tue, Feb 14, 2017 at 05:19:08PM +0800, Chunyan Zhang wrote: > > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupts = > + | IRQ_TYPE_LEVEL_LOW)>, > > + > + | IRQ_TYPE_LEVEL_LOW)>, > > + > + | IRQ_TYPE_LEVEL_LOW)>, > > + > + | IRQ_TYPE_LEVEL_LOW)>; > > + clock-frequency = <26000000>; > > + }; > > Your FW should program CNTFRQ on all CPUs, and this clock-frequency > property should not be necessary. Please remove it. > Will remove it. > > + > > + pmu { > > + compatible = "arm,armv8-pmuv3"; > > Please list "arm,cortex-a53-pmu" first. > > > + interrupts = , > > + , > > + , > > + , > > + , > > + , > > + , > > + ; > > + }; > > As you are using SPIs, please add an interrupt-affinity property, per > Documentation/devicetree/bindings/arm/pmu.txt. Added, would appear in the next revision. > > > diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > new file mode 100644 > > index 0000000..59390fc > > --- /dev/null > > +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > @@ -0,0 +1,58 @@ > > +/* > > + * Spreadtrum SP9860g board DTS file > > + * > > + * Copyright (C) 2017, Spreadtrum Communications Inc. > > + * > > + * This file is licensed under a dual GPLv2 or X11 license. > > + */ > > + > > +/dts-v1/; > > + > > +#include "sc9860.dtsi" > > + > > +/ { > > + model = "Spreadtrum SP9860G 3GFHD Board"; > > + > > + compatible = "sprd,sc9860", "sprd,sp9860g-1h10"; > > + > > + sprd,sc-id = <9860 1 0x20000>; > > What is this? I can't see any documentation or user of this property in > mainline. > I will remove this property in the next iteration, actually this is for Spreadtrum's dtb tools only, I just forgot to remove it before sending this patch out. Thanks, Chunyan > > Thanks, > Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chunyan Zhang Subject: Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Date: Thu, 16 Feb 2017 15:57:14 +0800 Message-ID: <20170216075713.GA8569@spreadtrum.com> References: <1487063952-7113-1-git-send-email-chunyan.zhang@spreadtrum.com> <1487063952-7113-2-git-send-email-chunyan.zhang@spreadtrum.com> <20170214155743.GG23718@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20170214155743.GG23718@leverpostej> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Rutland Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, orson.zhai-lxIno14LUO0EEoCn2XhGlw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, nd-5wv7dgnIgG8@public.gmane.org List-Id: devicetree@vger.kernel.org On 二, 2月 14, 2017 at 03:57:43下午 +0000, Mark Rutland wrote: > Hi, > > On Tue, Feb 14, 2017 at 05:19:08PM +0800, Chunyan Zhang wrote: > > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupts = > + | IRQ_TYPE_LEVEL_LOW)>, > > + > + | IRQ_TYPE_LEVEL_LOW)>, > > + > + | IRQ_TYPE_LEVEL_LOW)>, > > + > + | IRQ_TYPE_LEVEL_LOW)>; > > + clock-frequency = <26000000>; > > + }; > > Your FW should program CNTFRQ on all CPUs, and this clock-frequency > property should not be necessary. Please remove it. > Will remove it. > > + > > + pmu { > > + compatible = "arm,armv8-pmuv3"; > > Please list "arm,cortex-a53-pmu" first. > > > + interrupts = , > > + , > > + , > > + , > > + , > > + , > > + , > > + ; > > + }; > > As you are using SPIs, please add an interrupt-affinity property, per > Documentation/devicetree/bindings/arm/pmu.txt. Added, would appear in the next revision. > > > diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > new file mode 100644 > > index 0000000..59390fc > > --- /dev/null > > +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > @@ -0,0 +1,58 @@ > > +/* > > + * Spreadtrum SP9860g board DTS file > > + * > > + * Copyright (C) 2017, Spreadtrum Communications Inc. > > + * > > + * This file is licensed under a dual GPLv2 or X11 license. > > + */ > > + > > +/dts-v1/; > > + > > +#include "sc9860.dtsi" > > + > > +/ { > > + model = "Spreadtrum SP9860G 3GFHD Board"; > > + > > + compatible = "sprd,sc9860", "sprd,sp9860g-1h10"; > > + > > + sprd,sc-id = <9860 1 0x20000>; > > What is this? I can't see any documentation or user of this property in > mainline. > I will remove this property in the next iteration, actually this is for Spreadtrum's dtb tools only, I just forgot to remove it before sending this patch out. Thanks, Chunyan > > Thanks, > Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754021AbdBPIA1 (ORCPT ); Thu, 16 Feb 2017 03:00:27 -0500 Received: from sci-ig2.spreadtrum.com ([222.66.158.135]:19509 "EHLO SHSQR01.spreadtrum.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752712AbdBPIA0 (ORCPT ); Thu, 16 Feb 2017 03:00:26 -0500 Date: Thu, 16 Feb 2017 15:57:14 +0800 From: Chunyan Zhang To: Mark Rutland CC: , , , , , , , , , Subject: Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Message-ID: <20170216075713.GA8569@spreadtrum.com> Mail-Followup-To: Mark Rutland , robh+dt@kernel.org, gregkh@linuxfoundation.org, catalin.marinas@arm.com, will.deacon@arm.com, arnd@arndb.de, orson.zhai@spreadtrum.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nd@arm.com References: <1487063952-7113-1-git-send-email-chunyan.zhang@spreadtrum.com> <1487063952-7113-2-git-send-email-chunyan.zhang@spreadtrum.com> <20170214155743.GG23718@leverpostej> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170214155743.GG23718@leverpostej> User-Agent: Mutt/1.5.21 (2010-09-15) X-MAIL: SHSQR01.spreadtrum.com v1G7vhTx079741 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 二, 2月 14, 2017 at 03:57:43下午 +0000, Mark Rutland wrote: > Hi, > > On Tue, Feb 14, 2017 at 05:19:08PM +0800, Chunyan Zhang wrote: > > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupts = > + | IRQ_TYPE_LEVEL_LOW)>, > > + > + | IRQ_TYPE_LEVEL_LOW)>, > > + > + | IRQ_TYPE_LEVEL_LOW)>, > > + > + | IRQ_TYPE_LEVEL_LOW)>; > > + clock-frequency = <26000000>; > > + }; > > Your FW should program CNTFRQ on all CPUs, and this clock-frequency > property should not be necessary. Please remove it. > Will remove it. > > + > > + pmu { > > + compatible = "arm,armv8-pmuv3"; > > Please list "arm,cortex-a53-pmu" first. > > > + interrupts = , > > + , > > + , > > + , > > + , > > + , > > + , > > + ; > > + }; > > As you are using SPIs, please add an interrupt-affinity property, per > Documentation/devicetree/bindings/arm/pmu.txt. Added, would appear in the next revision. > > > diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > new file mode 100644 > > index 0000000..59390fc > > --- /dev/null > > +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > @@ -0,0 +1,58 @@ > > +/* > > + * Spreadtrum SP9860g board DTS file > > + * > > + * Copyright (C) 2017, Spreadtrum Communications Inc. > > + * > > + * This file is licensed under a dual GPLv2 or X11 license. > > + */ > > + > > +/dts-v1/; > > + > > +#include "sc9860.dtsi" > > + > > +/ { > > + model = "Spreadtrum SP9860G 3GFHD Board"; > > + > > + compatible = "sprd,sc9860", "sprd,sp9860g-1h10"; > > + > > + sprd,sc-id = <9860 1 0x20000>; > > What is this? I can't see any documentation or user of this property in > mainline. > I will remove this property in the next iteration, actually this is for Spreadtrum's dtb tools only, I just forgot to remove it before sending this patch out. Thanks, Chunyan > > Thanks, > Mark.