From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 16 Feb 2017 10:50:42 +0000 Subject: [patch] drm/msm/dsi: free first element on error Message-Id: <20170216105042.GA25544@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Rob Clark , Archit Taneja Cc: Rob Herring , David Airlie , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Wei Yongjun , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Hai Li We want to free msm_host->bus_clks[0] so the > should be >=. Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 1fc07ce24686..239e79b39a45 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -437,7 +437,7 @@ static int dsi_bus_clk_enable(struct msm_dsi_host *msm_host) return 0; err: - for (; i > 0; i--) + for (; i >= 0; i--) clk_disable_unprepare(msm_host->bus_clks[i]); return ret; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drm/msm/dsi: free first element on error Date: Thu, 16 Feb 2017 13:50:42 +0300 Message-ID: <20170216105042.GA25544@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Rob Clark , Archit Taneja Cc: Rob Herring , David Airlie , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Wei Yongjun , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Hai Li List-Id: linux-arm-msm@vger.kernel.org V2Ugd2FudCB0byBmcmVlIG1zbV9ob3N0LT5idXNfY2xrc1swXSBzbyB0aGUgPiBzaG91bGQgYmUg Pj0uCgpGaXhlczogNmUwZWI1MmViYTllICgiZHJtL21zbS9kc2k6IFBhcnNlIGJ1cyBjbG9ja3Mg ZnJvbSBhIGxpc3QiKQpTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVy QG9yYWNsZS5jb20+CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9kc2kvZHNpX2hv c3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZHNpL2RzaV9ob3N0LmMKaW5kZXggMWZjMDdjZTI0 Njg2Li4yMzllNzliMzlhNDUgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZHNpL2Rz aV9ob3N0LmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kc2kvZHNpX2hvc3QuYwpAQCAtNDM3 LDcgKzQzNyw3IEBAIHN0YXRpYyBpbnQgZHNpX2J1c19jbGtfZW5hYmxlKHN0cnVjdCBtc21fZHNp X2hvc3QgKm1zbV9ob3N0KQogCiAJcmV0dXJuIDA7CiBlcnI6Ci0JZm9yICg7IGkgPiAwOyBpLS0p CisJZm9yICg7IGkgPj0gMDsgaS0tKQogCQljbGtfZGlzYWJsZV91bnByZXBhcmUobXNtX2hvc3Qt PmJ1c19jbGtzW2ldKTsKIAogCXJldHVybiByZXQ7Cl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkZyZWVkcmVubyBtYWlsaW5nIGxpc3QKRnJlZWRyZW5vQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ZyZWVkcmVubwo=