From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 16 Feb 2017 11:53:07 +0000 Subject: Re: [patch] drm/msm/dsi: free first element on error Message-Id: <20170216115307.GD4108@mwanda> List-Id: References: <20170216105042.GA25544@mwanda> <87a89mnznw.fsf@intel.com> In-Reply-To: <87a89mnznw.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jani Nikula Cc: Archit Taneja , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wei Yongjun , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Rob Clark , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org On Thu, Feb 16, 2017 at 01:27:47PM +0200, Jani Nikula wrote: > On Thu, 16 Feb 2017, Dan Carpenter wrote: > > We want to free msm_host->bus_clks[0] so the > should be >=. > > > > Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") > > Signed-off-by: Dan Carpenter > > > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > > index 1fc07ce24686..239e79b39a45 100644 > > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > > @@ -437,7 +437,7 @@ static int dsi_bus_clk_enable(struct msm_dsi_host *msm_host) > > > > return 0; > > err: > > - for (; i > 0; i--) > > + for (; i >= 0; i--) > > clk_disable_unprepare(msm_host->bus_clks[i]); > > By the looks of it this is also wrong. I didn't look at the functions, > but you probably don't want to unprepare something where prepare failed, > i.e. you want to -1 both the start and end offsets. Perhaps the right > fix is > > while (i--) > clk_disable_unprepare(msm_host->bus_clks[i]); > > which also seems to be widely used on error paths. > Ah yeah. You're right. I'll resend. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch] drm/msm/dsi: free first element on error Date: Thu, 16 Feb 2017 14:53:07 +0300 Message-ID: <20170216115307.GD4108@mwanda> References: <20170216105042.GA25544@mwanda> <87a89mnznw.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <87a89mnznw.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Jani Nikula Cc: Archit Taneja , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wei Yongjun , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Rob Clark , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gVGh1LCBGZWIgMTYsIDIwMTcgYXQgMDE6Mjc6NDdQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVGh1LCAxNiBGZWIgMjAxNywgRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBv cmFjbGUuY29tPiB3cm90ZToKPiA+IFdlIHdhbnQgdG8gZnJlZSBtc21faG9zdC0+YnVzX2Nsa3Nb MF0gc28gdGhlID4gc2hvdWxkIGJlID49Lgo+ID4KPiA+IEZpeGVzOiA2ZTBlYjUyZWJhOWUgKCJk cm0vbXNtL2RzaTogUGFyc2UgYnVzIGNsb2NrcyBmcm9tIGEgbGlzdCIpCj4gPiBTaWduZWQtb2Zm LWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+Cj4gPgo+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZHNpL2RzaV9ob3N0LmMgYi9kcml2ZXJzL2dw dS9kcm0vbXNtL2RzaS9kc2lfaG9zdC5jCj4gPiBpbmRleCAxZmMwN2NlMjQ2ODYuLjIzOWU3OWIz OWE0NSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZHNpL2RzaV9ob3N0LmMK PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZHNpL2RzaV9ob3N0LmMKPiA+IEBAIC00Mzcs NyArNDM3LDcgQEAgc3RhdGljIGludCBkc2lfYnVzX2Nsa19lbmFibGUoc3RydWN0IG1zbV9kc2lf aG9zdCAqbXNtX2hvc3QpCj4gPiAgCj4gPiAgCXJldHVybiAwOwo+ID4gIGVycjoKPiA+IC0JZm9y ICg7IGkgPiAwOyBpLS0pCj4gPiArCWZvciAoOyBpID49IDA7IGktLSkKPiA+ICAJCWNsa19kaXNh YmxlX3VucHJlcGFyZShtc21faG9zdC0+YnVzX2Nsa3NbaV0pOwo+IAo+IEJ5IHRoZSBsb29rcyBv ZiBpdCB0aGlzIGlzIGFsc28gd3JvbmcuIEkgZGlkbid0IGxvb2sgYXQgdGhlIGZ1bmN0aW9ucywK PiBidXQgeW91IHByb2JhYmx5IGRvbid0IHdhbnQgdG8gdW5wcmVwYXJlIHNvbWV0aGluZyB3aGVy ZSBwcmVwYXJlIGZhaWxlZCwKPiBpLmUuIHlvdSB3YW50IHRvIC0xIGJvdGggdGhlIHN0YXJ0IGFu ZCBlbmQgb2Zmc2V0cy4gUGVyaGFwcyB0aGUgcmlnaHQKPiBmaXggaXMKPiAKPiAJd2hpbGUgKGkt LSkKPiAJCWNsa19kaXNhYmxlX3VucHJlcGFyZShtc21faG9zdC0+YnVzX2Nsa3NbaV0pOwo+IAo+ IHdoaWNoIGFsc28gc2VlbXMgdG8gYmUgd2lkZWx5IHVzZWQgb24gZXJyb3IgcGF0aHMuCj4gCgpB aCB5ZWFoLiAgWW91J3JlIHJpZ2h0LiAgSSdsbCByZXNlbmQuCgpyZWdhcmRzLApkYW4gY2FycGVu dGVyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVl ZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8K