From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755046AbdBPOQN (ORCPT ); Thu, 16 Feb 2017 09:16:13 -0500 Received: from mx2.suse.de ([195.135.220.15]:32950 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754623AbdBPOQL (ORCPT ); Thu, 16 Feb 2017 09:16:11 -0500 Date: Thu, 16 Feb 2017 15:15:40 +0100 From: David Sterba To: "Dmitry V. Levin" Cc: Jeff Mahoney , Josef Bacik , Anand Jain , Liu Bo , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] btrfs: remove btrfs_err_str function from uapi/linux/btrfs.h Message-ID: <20170216141540.GS16928@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, "Dmitry V. Levin" , Jeff Mahoney , Josef Bacik , Anand Jain , Liu Bo , linux-kernel@vger.kernel.org References: <20170215200259.GA1028@altlinux.org> <20170215225503.GA2947@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170215225503.GA2947@altlinux.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 16, 2017 at 01:55:03AM +0300, Dmitry V. Levin wrote: > btrfs_err_str function is not called from anywhere and is replicated > in the userspace headers for btrfs-progs. > > It's removal also fixes the following linux/btrfs.h userspace > compilation error: > > /usr/include/linux/btrfs.h: In function 'btrfs_err_str': > /usr/include/linux/btrfs.h:740:11: error: 'NULL' undeclared (first use in this function) > return NULL; > > Suggested-by: Jeff Mahoney > Signed-off-by: Dmitry V. Levin Reviewed-by: David Sterba