From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933466AbdBPScV (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Feb 2017 13:32:21 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:58718 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932302AbdBPScU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Feb 2017 13:32:20 -0500
Date: Thu, 16 Feb 2017 10:32:18 -0800
From: Greg KH <gregkh@linuxfoundation.org>
To: SIMRAN SINGHAL <singhalsimran0@gmail.com>
Cc: Joe Perches <joe@perches.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues
Message-ID: <20170216183218.GB5188@kroah.com>
References: <20170214201432.GA4150@singhal-Inspiron-5558>
 <1487103799.6214.27.camel@perches.com>
 <CALrZqyNoZkhtNR60MJMBfceir4EUVzG_jNoxf-p6QkwZtj9_5A@mail.gmail.com>
 <1487129480.6214.39.camel@perches.com>
 <CALrZqyPyJ9Z5N91G073hAEr=YTD5BvRUVCikbBh1kxXiq5dx+g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALrZqyPyJ9Z5N91G073hAEr=YTD5BvRUVCikbBh1kxXiq5dx+g@mail.gmail.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 15, 2017 at 01:48:13PM +0530, SIMRAN SINGHAL wrote:
> On Wed, Feb 15, 2017 at 9:01 AM, Joe Perches <joe@perches.com> wrote:
> > On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote:
> >> Yes, I totally agree with joe.
> >>
> >> But as there is no coding style issue in this patch.
> >
> > Style is more than just checkpatch conformity.
> >
> >> So, do I have to resend the complete patch series again?
> >
> > I'm not applying any of these so that's entirely up
> > to Greg.
> >
> > Perhaps he might apply the first 5 patches and reject
> > this one, maybe he might apply all the patches.
> >
> > In any case, do strive to develop some reasonable
> > semblance of style and do more than just checkpatch
> > suggested patches and find and fix some actual defect
> > somewhere.
> 
> Joe, I am new to Linux kernel and just have basic knowledge of
>  C and C++.

As Joe said, the kernel is _not_ the project to learn C with.  Please
get some more experience with userspace programs in C first, before
working on the kernel.  It will be much easier for you.

thanks,

greg k-h