All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: simran singhal <singhalsimran0@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/9] staging: rtl8192u: Fixing style issues in r8180_93cx6.c
Date: Thu, 16 Feb 2017 10:32:58 -0800	[thread overview]
Message-ID: <20170216183258.GC5188@kroah.com> (raw)
In-Reply-To: <20170214201518.GA5133@singhal-Inspiron-5558>

On Wed, Feb 15, 2017 at 01:45:18AM +0530, simran singhal wrote:
> Fixing the following checkpatch.pl errors and warning:
> WARNING: Block comments use * on subsequent lines
> 
> CHECK: Please don't use multiple blank lines
> 
> CHECK: Alignment should match open parenthesis
> 
> CHECK: spaces preferred around that '<<'
> 
> CHECK: spaces preferred around that '-'
> 
> CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>

That's a lot of different things all in one patch.  Please don't do
that, break up into individual patches.

greg k-h

      reply	other threads:[~2017-02-16 18:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 20:15 [PATCH v2 7/9] staging: rtl8192u: Fixing style issues in r8180_93cx6.c simran singhal
2017-02-16 18:32 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170216183258.GC5188@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=singhalsimran0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.