All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: simran singhal <singhalsimran0@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/9] staging: rtl8192u: fixing white space issue
Date: Thu, 16 Feb 2017 10:34:35 -0800	[thread overview]
Message-ID: <20170216183435.GA5486@kroah.com> (raw)
In-Reply-To: <20170214200713.GA29669@singhal-Inspiron-5558>

On Wed, Feb 15, 2017 at 01:37:13AM +0530, simran singhal wrote:
> Fix the following checkpatch.pl error and warnings:
> WARNING: please, no space before tabs
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> index 873969c..a54dfad 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> @@ -30,7 +30,7 @@ typedef struct _TX_TS_RECORD{
>  	u16				TxCurSeq;
>  	BA_RECORD			TxPendingBARecord;	/*  For BA Originator */
>  	BA_RECORD			TxAdmittedBARecord;	/*  For BA Originator */
> -/* 	QOS_DL_RECORD		DLRecord; */
> +/*	QOS_DL_RECORD	DLRecord; */

Why did you change the number of tabs here?

Also, just delete unused fields, why keep them around?

thanks,

greg k-h

      reply	other threads:[~2017-02-16 18:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 20:07 [PATCH v2 1/9] staging: rtl8192u: fixing white space issue simran singhal
2017-02-16 18:34 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170216183435.GA5486@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=singhalsimran0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.