From: Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org>
To: Joshua Clayton <stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Alan Tull
<atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
Moritz Fischer
<moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH 1/2] dt: bindings: fpga: add xilinx slave-serial binding description
Date: Thu, 16 Feb 2017 19:51:23 +0100 [thread overview]
Message-ID: <20170216195123.5160fe5a@crub> (raw)
In-Reply-To: <a2403d1f-cb82-70ce-ecff-45e5901dabc2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Joshua,
On Thu, 16 Feb 2017 09:24:09 -0800
Joshua Clayton stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
...
>> + fpga_mgr_spi: fpga-spi@0 {
>> + compatible = "xlnx,fpga-slave-serial";
>> + spi-max-frequency = <60000000>;
>> + spi-cpha;
>> + reg = <0>;
>> + done-gpio = <&gpio0 9 GPIO_ACTIVE_HIGH>;
>> + prog_b-gpio = <&gpio0 29 GPIO_ACTIVE_LOW>;
>> + };
>nit: you've put prog_b-gpios and done-gpios in the description,
>but the example still has "prog_b-gpio" and "done-gpio"
Thanks for catching that! I copy pasted them from my testing .dts
but now I see that gpio suffix is deprecated for new gpio bindings.
Will fix the example in next patch version.
Thanks,
Anatolij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-16 18:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 15:10 [PATCH 0/2] Xilinx Slave Serial FPGA Manager Anatolij Gustschin
[not found] ` <1487257860-31115-1-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2017-02-16 15:10 ` [PATCH 1/2] dt: bindings: fpga: add xilinx slave-serial binding description Anatolij Gustschin
[not found] ` <1487257860-31115-2-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2017-02-16 17:24 ` Joshua Clayton
[not found] ` <a2403d1f-cb82-70ce-ecff-45e5901dabc2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-16 18:51 ` Anatolij Gustschin [this message]
2017-02-16 17:36 ` Moritz Fischer
[not found] ` <CAAtXAHcpcwax-rH3quYF9QTOVfbTyxmpPLLbUyX=-aruQfADDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-16 18:54 ` Anatolij Gustschin
2017-02-16 15:11 ` [PATCH 2/2] fpga manager: Add Xilinx slave serial SPI driver Anatolij Gustschin
[not found] ` <1487257860-31115-3-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2017-02-21 16:49 ` Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216195123.5160fe5a@crub \
--to=agust-ynqeqjnshbs@public.gmane.org \
--cc=atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.