From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1cecGZ-0000lW-QK for mharc-qemu-trivial@gnu.org; Fri, 17 Feb 2017 01:43:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cecGW-0000jJ-Pm for qemu-trivial@nongnu.org; Fri, 17 Feb 2017 01:43:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cecGV-0002tF-Uy for qemu-trivial@nongnu.org; Fri, 17 Feb 2017 01:43:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45450) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cecGR-0002pE-Hu; Fri, 17 Feb 2017 01:43:31 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6822C4E4C7; Fri, 17 Feb 2017 06:43:31 +0000 (UTC) Received: from localhost (ovpn-8-33.pek2.redhat.com [10.72.8.33]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1H6hTWE009661; Fri, 17 Feb 2017 01:43:30 -0500 Date: Fri, 17 Feb 2017 14:43:27 +0800 From: Fam Zheng To: Chad Joan Cc: Laszlo Ersek , qemu-trivial@nongnu.org, Paolo Bonzini , qemu-devel@nongnu.org Message-ID: <20170217064327.GB21716@lemon.lan> References: <1933406e-2576-e687-3545-a72f3b999310@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 17 Feb 2017 06:43:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems. X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 06:43:38 -0000 On Thu, 02/16 12:47, Chad Joan wrote: > I am glad others are chiming in and might provide better solutions. > > Honestly, following the instructions at > http://wiki.qemu-project.org/Contribute/SubmitAPatch to-the-letter is quite > daunting to me, just to get one line of code changed. It might help if > that page had some kind of dead-simple example for trivial patches; > something like: > $ cd > $ git format-patch blah blah blah > $ maybe-some-other-command > $ # Now copy the contents of file xyz.patch into your email client and send > to qemu-devel@nongnu.org and qemu-trivial@nongnu.org Makes sense in general except for the sending part - email clients tend to damage the patch when you copy and paste by wrapping long lines or messing up other things. But your point is taken, we should make the first (or a one-shot) contribution as easy as possible. Fam From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cecGU-0000i9-PE for qemu-devel@nongnu.org; Fri, 17 Feb 2017 01:43:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cecGR-0002pb-Nr for qemu-devel@nongnu.org; Fri, 17 Feb 2017 01:43:34 -0500 Date: Fri, 17 Feb 2017 14:43:27 +0800 From: Fam Zheng Message-ID: <20170217064327.GB21716@lemon.lan> References: <1933406e-2576-e687-3545-a72f3b999310@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chad Joan Cc: Laszlo Ersek , qemu-trivial@nongnu.org, Paolo Bonzini , qemu-devel@nongnu.org On Thu, 02/16 12:47, Chad Joan wrote: > I am glad others are chiming in and might provide better solutions. > > Honestly, following the instructions at > http://wiki.qemu-project.org/Contribute/SubmitAPatch to-the-letter is quite > daunting to me, just to get one line of code changed. It might help if > that page had some kind of dead-simple example for trivial patches; > something like: > $ cd > $ git format-patch blah blah blah > $ maybe-some-other-command > $ # Now copy the contents of file xyz.patch into your email client and send > to qemu-devel@nongnu.org and qemu-trivial@nongnu.org Makes sense in general except for the sending part - email clients tend to damage the patch when you copy and paste by wrapping long lines or messing up other things. But your point is taken, we should make the first (or a one-shot) contribution as easy as possible. Fam