From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Andrew Jones <drjones@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"James Hogan" <james.hogan@imgtec.com>,
"Paul Mackerras" <paulus@ozlabs.org>,
"Christoffer Dall" <christoffer.dall@linaro.org>
Subject: Re: [PATCH 1/5] KVM: change API for requests to match bit operations
Date: Fri, 17 Feb 2017 10:52:53 +0100 [thread overview]
Message-ID: <20170217105253.12ce475d.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20170217094935.u7ne57y7ko6h2mnz@kamzik.brq.redhat.com>
On Fri, 17 Feb 2017 10:49:35 +0100
Andrew Jones <drjones@redhat.com> wrote:
> On Fri, Feb 17, 2017 at 10:30:14AM +0100, Cornelia Huck wrote:
> > On Thu, 16 Feb 2017 17:04:45 +0100
> > Radim Krčmář <rkrcmar@redhat.com> wrote:
> > > +static inline void kvm_request_set(unsigned req, struct kvm_vcpu *vcpu)
> >
> > Should we make req unsigned long as well, so that it matches the bit
> > api even more?
>
> The bitops API is inconsistent among architectures; some are int, some
> are unsigned int, some are unsigned long, and x86 is long. If we want
> to be consistent with something, then, IMO, we should be consistent with
> asm-generic/bitops, which is int, but actually unsigned makes more sense
> to me...
Inconsistent interfaces are great :/
Having (any) unsigned value makes the most sense to me as well.
next prev parent reply other threads:[~2017-02-17 9:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 16:04 [PATCH 0/5] KVM: rename and extend vcpu->requests API Radim Krčmář
2017-02-16 16:04 ` [PATCH 1/5] KVM: change API for requests to match bit operations Radim Krčmář
2017-02-17 9:30 ` Cornelia Huck
2017-02-17 9:49 ` Andrew Jones
2017-02-17 9:52 ` Cornelia Huck [this message]
2017-02-17 15:01 ` Radim Krčmář
2017-02-16 16:04 ` [PATCH 2/5] KVM: add KVM request variants without barrier Radim Krčmář
2017-02-23 10:57 ` Paolo Bonzini
2017-02-23 15:50 ` Radim Krčmář
2017-02-16 16:04 ` [PATCH 3/5] KVM: optimize kvm_make_all_cpus_request Radim Krčmář
2017-02-16 16:04 ` [PATCH 4/5] KVM: add __kvm_request_needs_mb Radim Krčmář
2017-02-16 19:49 ` David Hildenbrand
2017-02-16 21:31 ` Radim Krčmář
2017-02-17 8:46 ` Christian Borntraeger
2017-02-17 10:13 ` David Hildenbrand
2017-02-17 10:19 ` Christian Borntraeger
2017-02-17 11:28 ` Christian Borntraeger
2017-02-22 15:17 ` Radim Krčmář
2017-02-22 19:23 ` Christian Borntraeger
2017-02-23 15:43 ` Radim Krčmář
2017-02-22 19:57 ` Christian Borntraeger
2017-02-23 10:20 ` David Hildenbrand
2017-02-23 15:39 ` Radim Krčmář
2017-02-24 11:34 ` Christoffer Dall
2017-02-24 12:46 ` Andrew Jones
2017-02-23 11:01 ` Paolo Bonzini
2017-02-23 15:52 ` Radim Krčmář
2017-02-16 16:04 ` [PATCH 5/5] KVM: add kvm_request_pending Radim Krčmář
2017-02-16 19:50 ` David Hildenbrand
2017-02-17 9:51 ` Andrew Jones
2017-02-17 14:59 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217105253.12ce475d.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=christoffer.dall@linaro.org \
--cc=drjones@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.