All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/opengl: ensure consistency between the various providers
Date: Fri, 17 Feb 2017 11:04:36 +0100	[thread overview]
Message-ID: <20170217110436.0366d6f8@free-electrons.com> (raw)
In-Reply-To: <20684119.X7ZmMtA3r5@sagittae>

Hello,

On Fri, 17 Feb 2017 09:34:38 +0100, J?r?me Pouiller wrote:

> On Thursday 16 February 2017 18:46:10 CET Arnout Vandecappelle wrote:
> > 
> > On 14-02-17 22:13, Yann E. MORIN wrote:  
> > > Some GL providers will provide libegl and libgles, but not libgl, while
> > > other will provide libgl but not libegl not libgles. This can be the
> > > case with:
> > >   - mesa3d       -> libgl
> > >   - rpi-userland -> libegl and libgles  
> 
> Unfortunately, as far as I remember, this kind of configuration is
> necessary to build xdriver_xf86-video-imx-viv. Mesa is necessary to
> build GLX support but, EGL/GLes have to be provided by imx-gpu-viv.

Nope, it's not actually needed. Even with xdriver_xf86-video-imx-viv,
the OpenGL provider is imx-gpu-viv, as it's ultimately the one that
provides libGL.so.

However, it is true that imx-gpu-viv is a special case as it provides a
libGL.so that itself uses libraries provided by Mesa.

So the hack I've done so far is:

-	select BR2_PACKAGE_HAS_LIBGL if BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_HAS_LIBGL if BR2_PACKAGE_XORG7 && !BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_X11

and:

-	default "mesa3d" if BR2_PACKAGE_XORG7
+	default "mesa3d" if BR2_PACKAGE_XORG7 && !BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_X11
 
This is a quick hack, but it allows mesa3d to *NOT* be seen as an
OpenGL provider if imx-gpu-viv X11 support is enabled.

So I still think the rule should be: we support only one OpenGL
provider. And the rest should be solved by exposing mesa3d as an OpenGL
provider or not depending on Config.in options.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-02-17 10:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 21:13 [Buildroot] [PATCH] package/opengl: ensure consistency between the various providers Yann E. MORIN
2017-02-16 17:46 ` Arnout Vandecappelle
2017-02-16 17:56   ` Yann E. MORIN
2017-02-17  7:56     ` Arnout Vandecappelle
2017-02-17 22:19       ` Yann E. MORIN
2017-02-17  8:34   ` Jérôme Pouiller
2017-02-17 10:04     ` Thomas Petazzoni [this message]
2017-02-17 17:06       ` Jérôme Pouiller
2017-03-26 21:48 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170217110436.0366d6f8@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.