From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: simplify xfs_rtallocate_extent
Date: Fri, 17 Feb 2017 13:47:28 +0100 [thread overview]
Message-ID: <20170217124728.GE23739@lst.de> (raw)
In-Reply-To: <20170217010232.GI6813@birch.djwong.org>
On Thu, Feb 16, 2017 at 05:02:32PM -0800, Darrick J. Wong wrote:
> > ASSERT(xfs_isilocked(mp->m_rbmip, XFS_ILOCK_EXCL));
> > ASSERT(minlen > 0 && minlen <= maxlen);
> > -
> > +
>
> Inserted whitespace?
Yeah, fixed.
> > - if (error)
> > - return error;
>
> We shouldn't be ignoring errors from xfs_rtallocate_extent_*, right?
No, we shouldn't. I'll add the check back.
next prev parent reply other threads:[~2017-02-17 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 21:21 two small allocator cleanups Christoph Hellwig
2017-02-16 21:21 ` [PATCH 1/2] xfs: simplify xfs_rtallocate_extent Christoph Hellwig
2017-02-17 1:02 ` Darrick J. Wong
2017-02-17 12:47 ` Christoph Hellwig [this message]
2017-02-16 21:21 ` [PATCH 2/2] xfs: remove XFS_ALLOCTYPE_ANY_AG and XFS_ALLOCTYPE_START_AG Christoph Hellwig
2017-02-17 1:05 ` Darrick J. Wong
2017-02-17 12:45 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2017-02-17 12:49 two small allocator cleanups V2 Christoph Hellwig
2017-02-17 12:49 ` [PATCH 1/2] xfs: simplify xfs_rtallocate_extent Christoph Hellwig
2017-02-17 16:20 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217124728.GE23739@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.