From: Jiri Olsa <jolsa@redhat.com>
To: Jan Stancek <jstancek@redhat.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
mhiramat@kernel.org
Subject: Re: [PATCH v3 3/3] perf: replace _SC_NPROCESSORS_CONF with max_present_cpu in cpu_topology_map
Date: Fri, 17 Feb 2017 16:05:52 +0100 [thread overview]
Message-ID: <20170217150552.GA14510@krava> (raw)
In-Reply-To: <d7c05c6445fca74a8442c2c73cfffd349c52c44f.1487146877.git.jstancek@redhat.com>
On Fri, Feb 17, 2017 at 12:10:26PM +0100, Jan Stancek wrote:
SNIP
> - int cpu_nr = ph->env.nr_cpus_online;
> + int cpu_nr = ph->env.nr_cpus_avail;
>
> nr = ph->env.nr_sibling_cores;
> str = ph->env.sibling_cores;
> @@ -1792,7 +1786,7 @@ static int process_cpu_topology(struct perf_file_section *section,
> u32 nr, i;
> char *str;
> struct strbuf sb;
> - int cpu_nr = ph->env.nr_cpus_online;
> + int cpu_nr = ph->env.nr_cpus_avail;
> u64 size = 0;
>
> ph->env.cpu = calloc(cpu_nr, sizeof(*ph->env.cpu));
> @@ -1873,7 +1867,7 @@ static int process_cpu_topology(struct perf_file_section *section,
> if (ph->needs_swap)
> nr = bswap_32(nr);
>
> - if (nr > (u32)cpu_nr) {
> + if (nr != (u32)-1 && nr > (u32)cpu_nr) {
could you please add a comment here exaplaining the reason
for possible -1 in here.. other than that it's ok,
for the series:
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2017-02-17 15:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 16:53 [PATCH] perf: fix topology test on systems with sparse CPUs Jan Stancek
2017-01-30 18:49 ` Jiri Olsa
2017-01-30 19:29 ` Jan Stancek
2017-01-31 16:03 ` Jan Stancek
2017-02-02 11:29 ` Jiri Olsa
2017-02-02 12:06 ` Jan Stancek
2017-02-02 13:01 ` Jiri Olsa
2017-02-13 15:34 ` [PATCH v2 1/3] perf: add cpu__max_present_cpu() Jan Stancek
2017-02-13 15:34 ` [PATCH v2 2/3] perf: make build_cpu_topology skip offline/absent CPUs Jan Stancek
2017-02-14 11:01 ` Jiri Olsa
2017-02-15 8:48 ` Jan Stancek
2017-02-17 11:10 ` [PATCH v3 1/3] perf: add cpu__max_present_cpu() Jan Stancek
2017-02-17 11:10 ` [PATCH v3 2/3] perf: make build_cpu_topology skip offline/absent CPUs Jan Stancek
2017-02-17 15:36 ` Arnaldo Carvalho de Melo
2017-02-21 8:12 ` [tip:perf/urgent] perf header: Make " tip-bot for Jan Stancek
2017-02-17 11:10 ` [PATCH v3 3/3] perf: replace _SC_NPROCESSORS_CONF with max_present_cpu in cpu_topology_map Jan Stancek
2017-02-17 15:05 ` Jiri Olsa [this message]
2017-02-21 8:12 ` [tip:perf/urgent] perf tools: Replace " tip-bot for Jan Stancek
2017-02-21 8:11 ` [tip:perf/urgent] perf cpumap: Add cpu__max_present_cpu() tip-bot for Jan Stancek
2017-02-13 15:34 ` [PATCH v2 3/3] perf: replace _SC_NPROCESSORS_CONF with max_present_cpu in cpu_topology_map Jan Stancek
2017-02-14 11:17 ` [PATCH v2 1/3] perf: add cpu__max_present_cpu() Jiri Olsa
2017-02-02 11:29 ` [PATCH] perf: fix topology test on systems with sparse CPUs Jiri Olsa
2017-01-30 18:49 ` Jiri Olsa
2017-01-30 18:49 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217150552.GA14510@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jstancek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.