From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935118AbdBQVqO (ORCPT ); Fri, 17 Feb 2017 16:46:14 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:44091 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934415AbdBQVqN (ORCPT ); Fri, 17 Feb 2017 16:46:13 -0500 Date: Fri, 17 Feb 2017 22:46:10 +0100 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next v2 4/6] net: dsa: mv88e6xxx: move VTU code to its own file Message-ID: <20170217214610.GJ6096@lunn.ch> References: <20170217150531.2181-1-vivien.didelot@savoirfairelinux.com> <20170217150531.2181-5-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170217150531.2181-5-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 17, 2017 at 10:05:29AM -0500, Vivien Didelot wrote: > Move the Global (1) VTU related code to its own file. > > Use this opportunity to provide a cleaner API for the VTU, by renaming a > few underscore prefixed functions, split the data member of the > mv88e6xxx_vtu_entry structure into membership (for 802.1q) and port > state (for 802.1s) members, and add a mv88e6xxx_has_vtu() helper. Again, seperate move from cleanups please. Andrew