From: Greg KH <gregkh@linuxfoundation.org>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: ks7010: There should be no spaces at the start of a line
Date: Sat, 18 Feb 2017 17:57:14 +0100 [thread overview]
Message-ID: <20170218165714.GA24078@kroah.com> (raw)
In-Reply-To: <20170218164002.GA7269@arushi-HP-Pavilion-Notebook>
On Sat, Feb 18, 2017 at 10:10:02PM +0530, Arushi Singhal wrote:
> The following patch the checkpatch.pl warning:
> drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the
> start of a line
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/ks7010/ks_hostif.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index 819e08b5fa91..3b2e28749b63 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)
> }
> DPRINTK(4, "\n Link AP\n");
> DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \
> - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \
> - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability);
> +essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \
> +rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability);
So don't just remove the spaces, fix it correctly with the proper
indentation please.
thanks,
greg k-h
next prev parent reply other threads:[~2017-02-18 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 16:40 [PATCH] Staging: ks7010: There should be no spaces at the start of a line Arushi Singhal
2017-02-18 16:57 ` Greg KH [this message]
2017-02-19 15:18 ` Arushi Singhal
2017-02-19 15:34 ` [Outreachy kernel] " Julia Lawall
2017-02-18 17:00 ` [Outreachy kernel] " Julia Lawall
2017-02-19 18:27 ` Joe Perches
2017-02-19 18:27 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170218165714.GA24078@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.