All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: Romain Perier <romain.perier@gmail.com>
Cc: yocto@yoctoproject.org, Jacob Chen <jacob-chen@iotwrt.com>
Subject: Re: [meta-rockchip][PATCH 3/3] rockchip-next-img: add image for rockchip next-dev u-boot
Date: Sat, 18 Feb 2017 21:37:30 -0500	[thread overview]
Message-ID: <20170219023730.GA18681@linux-uys3> (raw)
In-Reply-To: <CABgxDo+N34NQhr7s+5oU7Kg_=omN49PVAit7PZ_UuoBG8wdHUg@mail.gmail.com>

On Sat 2017-02-18 @ 06:50:05 PM, Romain Perier wrote:
> 1 patch per feature or per different component. So  I should get a patch
> for rk3288.inc and another one for the class :)

I could argue that this is one patch since the only way to flash (for example)
the Firefly is to use the image this class generates so now that this bbclass
exists, rk3288 builds should be using it.

In any case I've split them up and taken the opportunity to rename and re-work
the commit.

> Suppose I am a user of meta-rockchip. I want to use a class for generating
> a image. The name "rockchip-img-next" is not clear at all for me.
> If that's for the sdcard call it rockchip-img-sdmmc if later you plan to
> add a class for emmc call it rockchip-img-emmc :)

Agreed, it is too vague. A v2 is on its way! :-)


      reply	other threads:[~2017-02-19  2:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-17 18:07 [meta-rockchip][PATCH 0/3] firefly gpt emmc update Trevor Woerner
2017-02-17 18:07 ` [meta-rockchip][PATCH 1/3] remove DEFAULTTUNEs Trevor Woerner
2017-02-17 18:07 ` [meta-rockchip][PATCH 2/3] u-boot-rockchip: add Trevor Woerner
2017-02-18 17:42   ` Romain Perier
2017-02-17 18:07 ` [meta-rockchip][PATCH 3/3] rockchip-next-img: add image for rockchip next-dev u-boot Trevor Woerner
2017-02-18 17:50   ` Romain Perier
2017-02-19  2:37     ` Trevor Woerner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170219023730.GA18681@linux-uys3 \
    --to=twoerner@gmail.com \
    --cc=jacob-chen@iotwrt.com \
    --cc=romain.perier@gmail.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.