From: Pranith Kumar <bobby.prani@gmail.com>
To: alex.bennee@linaro.org
Cc: qemu-devel@nongnu.org, rth@twiddle.net
Subject: [Qemu-devel] [PATCH] mttcg: Set jmp_env to handle exit from tb_gen_code
Date: Mon, 20 Feb 2017 09:53:35 -0500 [thread overview]
Message-ID: <20170220145335.591-1-bobby.prani@gmail.com> (raw)
tb_gen_code() can exit execution using cpu_exit_loop() when it cannot
allocate new tb's. To handle this, we need to properly set the jmp_env
pointer ahead of calling tb_gen_code().
CC:Alex Bennée <alex.bennee@linaro.org>
CC: Richard Henderson <rth@twiddle.net>
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
cpu-exec.c | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/cpu-exec.c b/cpu-exec.c
index 97d79612d9..4b70988b24 100644
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -236,23 +236,22 @@ static void cpu_exec_step(CPUState *cpu)
cpu_get_tb_cpu_state(env, &pc, &cs_base, &flags);
tb_lock();
- tb = tb_gen_code(cpu, pc, cs_base, flags,
- 1 | CF_NOCACHE | CF_IGNORE_ICOUNT);
- tb->orig_tb = NULL;
- tb_unlock();
-
- cc->cpu_exec_enter(cpu);
-
if (sigsetjmp(cpu->jmp_env, 0) == 0) {
+ tb = tb_gen_code(cpu, pc, cs_base, flags,
+ 1 | CF_NOCACHE | CF_IGNORE_ICOUNT);
+ tb->orig_tb = NULL;
+ tb_unlock();
+
+ cc->cpu_exec_enter(cpu);
/* execute the generated code */
trace_exec_tb_nocache(tb, pc);
cpu_tb_exec(cpu, tb);
- }
+ cc->cpu_exec_exit(cpu);
- cc->cpu_exec_exit(cpu);
- tb_lock();
- tb_phys_invalidate(tb, -1);
- tb_free(tb);
+ tb_lock();
+ tb_phys_invalidate(tb, -1);
+ tb_free(tb);
+ }
tb_unlock();
}
--
2.11.0
next reply other threads:[~2017-02-20 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 14:53 Pranith Kumar [this message]
2017-02-20 16:16 ` [Qemu-devel] [PATCH] mttcg: Set jmp_env to handle exit from tb_gen_code Alex Bennée
2017-02-20 23:56 ` Pranith Kumar
2017-02-21 0:35 ` Alex Bennée
2017-02-21 4:05 ` Pranith Kumar
2017-02-21 15:04 ` Alex Bennée
2017-02-21 16:17 ` Pranith Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220145335.591-1-bobby.prani@gmail.com \
--to=bobby.prani@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.