From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/sunxi-mali: reorder select/depends
Date: Mon, 20 Feb 2017 22:50:31 +0100 [thread overview]
Message-ID: <20170220225031.0d382b73@free-electrons.com> (raw)
In-Reply-To: <20170218145258.10213-1-romain.naour@gmail.com>
Hello,
On Sat, 18 Feb 2017 15:52:57 +0100, Romain Naour wrote:
> From [1]:
> "Even though the ordering has absolutely no consequences in Kconfig, it
> is not logical (when reading). It is more logical and far easier to
> understand when depends come first, followed by the selects."
>
> Also, the Config.in example in the manual suggests to use this coding
> style [2].
>
> [1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html
> [2] https://buildroot.org/downloads/manual/manual.html#writing-rules-config-in
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> package/sunxi-mali/Config.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2017-02-20 21:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 14:52 [Buildroot] [PATCH 1/2] package/sunxi-mali: reorder select/depends Romain Naour
2017-02-18 14:52 ` [Buildroot] [PATCH 2/2] package/sunxi-mali: remove sunxi-mali r2p4 kernel module Romain Naour
2017-02-18 15:05 ` Yann E. MORIN
2017-02-18 15:16 ` Romain Naour
2017-02-20 21:52 ` Thomas Petazzoni
2017-02-20 22:33 ` Romain Naour
2017-02-20 21:50 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220225031.0d382b73@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.