From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: kernel development process question, patch review
Date: Tue, 21 Feb 2017 08:02:47 +0100 [thread overview]
Message-ID: <20170221070247.GA8499@kroah.com> (raw)
In-Reply-To: <20170221013533.GA23212@eros>
On Tue, Feb 21, 2017 at 12:35:33PM +1100, Tobin C. Harding wrote:
> If a reviewer makes a suggestion and one intends on making the change
> as suggested is it required (normal protocol) to reply stating that
> the you understand their suggestion and intend on implementing it or
> is this just noise. Should one simply re send the next version of the
> patch?
If you were a reviewer, which would you like to see happen if you took
the time to review someone else's work?
> Continuing on this theme, should one add a Suggested-by: tag in the
> previous situation. Some where Documentation/process it states that no
> tag except the CC tag should be added without the authority of the
> person being named?
Suggested-by: is usually for the whole idea of the patch itself, not for
revisions within a patch.
good luck!
greg k-h
next prev parent reply other threads:[~2017-02-21 7:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 1:35 kernel development process question, patch review Tobin C. Harding
2017-02-21 7:02 ` Greg KH [this message]
2017-02-21 17:29 ` Ozgur Karatas
2017-02-21 17:32 ` Ozgur Karatas
2017-02-21 19:40 ` valdis.kletnieks at vt.edu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221070247.GA8499@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.