All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (hch@infradead.org)
Subject: [PATCHv2 1/2] nvme-rdma: move nvme cm status helper to .h file
Date: Tue, 21 Feb 2017 01:27:05 -0800	[thread overview]
Message-ID: <20170221092705.GA27568@infradead.org> (raw)
In-Reply-To: <d21d9ca9-92fe-5994-d09a-f6ad37bbd099@mellanox.com>

On Tue, Feb 21, 2017@11:24:24AM +0200, Max Gurtovoy wrote:
> Hi Bart,
> 
> Currently we don't have any .c file to put this function implementation
> without creating a code duplication and module dependencies.
> I think that this new solution is better than code duplication, right ?

Yes, it is - especially given that it's just a bit of constant and not
much code anyway, and each new module would take up at least a page of
memory.

  reply	other threads:[~2017-02-21  9:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-20 11:44 [PATCHv2 1/2] nvme-rdma: move nvme cm status helper to .h file Max Gurtovoy
2017-02-20 11:44 ` [PATCHv2 2/2] nvmet-rdma: use nvme cm status helper Max Gurtovoy
2017-02-20 16:04 ` [PATCHv2 1/2] nvme-rdma: move nvme cm status helper to .h file Christoph Hellwig
2017-02-20 17:03 ` Bart Van Assche
2017-02-21  9:24   ` Max Gurtovoy
2017-02-21  9:27     ` hch [this message]
2017-02-21 10:52       ` Max Gurtovoy
2017-02-21 21:21         ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170221092705.GA27568@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.