From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 2/2] drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC Date: Tue, 21 Feb 2017 12:55:01 +0200 Message-ID: <20170221105501.GC31595@intel.com> References: <20170221100059.GD17643@sill.h.stcim.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C29A06E626 for ; Tue, 21 Feb 2017 10:55:05 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170221100059.GD17643@sill.h.stcim.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stefan Lengfeld Cc: Daniel Vetter , Maxime Ripard , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBGZWIgMjEsIDIwMTcgYXQgMTE6MDA6NTlBTSArMDEwMCwgU3RlZmFuIExlbmdmZWxk IHdyb3RlOgo+IEhpIE1heGltZSwKPiAKPiBPbiBXZWQsIEZlYiAxNSwgMjAxNyBhdCAwNToxOTow OVBNICswMTAwLCBNYXhpbWUgUmlwYXJkIHdyb3RlOgo+ID4gRnJvbTogU3RlZmFuIENocmlzdCA8 cy5jaHJpc3RAcGh5dGVjLmRlPgo+ID4gCj4gCj4gTWF5YmUgY2hhbmdlIHRoZSBhdXRob3IgaGVy ZS4gT25seSB0aGUgYm9pbGVycGxhdGUgY29kZSBsb29rcyBteSBvcmlnaW5hbAo+IHBhdGNoLiBU aGUgcmVhbCBjb2RlIGlzIHlvdXIgd29yayA7LSkKPiAKPiA+IEltcGxlbWVudCBsZWdhY3kgZnJh bWVidWZmZXIgaW9jdGwgRkJJT19XQUlURk9SVlNZTkMgaW4gdGhlIGdlbmVyaWMKPiA+IGZyYW1l YnVmZmVyIGVtdWxhdGlvbiBkcml2ZXIuIExlZ2FjeSBmcmFtZWJ1ZmZlciB1c2VycyBsaWtlIG5v biBrbXMvZHJtCj4gPiBiYXNlZCBPcGVuR0woRVMpL0VHTCBpbXBsZW1lbnRhdGlvbnMgbWF5IHJl cXVpcmUgdGhlIGlvY3RsIHRvCj4gPiBzeW5jaHJvbml6ZSBkcmF3aW5nIG9yIGJ1ZmZlciBmbGlw IGZvciBkb3VibGUgYnVmZmVyaW5nLiBJdCBpcyB0ZXN0ZWQgb24KPiA+IHRoZSBpLk1YNi4KPiA+ IAo+ID4gQ29kZSBpcyBiYXNlZCBvbgo+ID4gICAgIGh0dHBzOi8vZ2l0aHViLmNvbS9YaWxpbngv bGludXgteGxueC9ibG9iL21hc3Rlci9kcml2ZXJzL2dwdS9kcm0veGlsaW54L3hpbGlueF9kcm1f ZmIuYyNMMTk2Cj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFN0ZWZhbiBDaHJpc3QgPHMuY2hyaXN0 QHBoeXRlYy5kZT4KPiA+IFNpZ25lZC1vZmYtYnk6IE1heGltZSBSaXBhcmQgPG1heGltZS5yaXBh cmRAZnJlZS1lbGVjdHJvbnMuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9m Yl9oZWxwZXIuYyB8IDYzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCj4gPiAg aW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oICAgICB8IDEyICsrKysrLQo+ID4gIDIgZmlsZXMg Y2hhbmdlZCwgNzQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fZmJfaGVscGVyLmMKPiA+IGluZGV4IGM2ZGU4N2FiYWNhOC4uMTVlZTk2NDFjNzI1IDEwMDY0 NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+ID4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+ID4gQEAgLTEyNDAsNiArMTI0MCw2OSBAQCBp bnQgZHJtX2ZiX2hlbHBlcl9zZXRjbWFwKHN0cnVjdCBmYl9jbWFwICpjbWFwLCBzdHJ1Y3QgZmJf aW5mbyAqaW5mbykKPiA+ICBFWFBPUlRfU1lNQk9MKGRybV9mYl9oZWxwZXJfc2V0Y21hcCk7Cj4g PiAgCj4gPiAgLyoqCj4gPiArICogZHJtX2ZiX2hlbHBlcl9pb2N0bCAtIGxlZ2FjeSBpb2N0bCBp bXBsZW1lbnRhdGlvbgo+ID4gKyAqIEBpbmZvOiBmYmRldiByZWdpc3RlcmVkIGJ5IHRoZSBoZWxw ZXIKPiA+ICsgKiBAY21kOiBpb2N0bCBjb21tYW5kCj4gPiArICogQGFyZzogaW9jdGwgYXJndW1l bnQKPiA+ICsgKgo+ID4gKyAqIEEgaGVscGVyIHRvIGltcGxlbWVudCB0aGUgc3RhbmRhcmQgZmJk ZXYgaW9jdGwuIE9ubHkKPiA+ICsgKiBGQklPX1dBSVRGT1JWU1lOQyBpcyBpbXBsZW1lbnRlZCBm b3Igbm93Lgo+ID4gKyAqLwo+ID4gK2ludCBkcm1fZmJfaGVscGVyX2lvY3RsKHN0cnVjdCBmYl9p bmZvICppbmZvLCB1bnNpZ25lZCBpbnQgY21kLAo+ID4gKwkJCXVuc2lnbmVkIGxvbmcgYXJnKQo+ ID4gK3sKPiA+ICsJc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlciA9IGluZm8tPnBhcjsK PiA+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGZiX2hlbHBlci0+ZGV2Owo+ID4gKwlzdHJ1 Y3QgZHJtX21vZGVfc2V0ICptb2RlX3NldDsKPiA+ICsJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ ID4gKwl1MzIga2FyZzsKPiA+ICsJaW50IHJldCA9IDA7Cj4gPiArCj4gPiArCW11dGV4X2xvY2so JmRldi0+bW9kZV9jb25maWcubXV0ZXgpOwo+ID4gKwlpZiAoIWRybV9mYl9oZWxwZXJfaXNfYm91 bmQoZmJfaGVscGVyKSkgewo+ID4gKwkJcmV0ID0gLUVCVVNZOwo+ID4gKwkJZ290byB1bmxvY2s7 Cj4gPiArCX0KPiA+ICsKPiA+ICsJc3dpdGNoIChjbWQpIHsKPiA+ICsJY2FzZSBGQklPX1dBSVRG T1JWU1lOQzoKPiA+ICsJCWlmIChnZXRfdXNlcihrYXJnLCAoX191MzIgX191c2VyICopYXJnKSkg ewo+ID4gKwkJCXJldCA9IC1FRkFVTFQ7Cj4gPiArCQkJZ290byB1bmxvY2s7Cj4gPiArCQl9Cj4g PiArCj4gPiArCQlpZiAoa2FyZyA+PSBmYl9oZWxwZXItPmNydGNfY291bnQpIHsKPiA+ICsJCQly ZXQgPSAtRUlOVkFMOwo+ID4gKwkJCWdvdG8gdW5sb2NrOwo+ID4gKwkJfQo+IAo+IFZpbGxlIFN5 cmrDpGzDpCBzYWlkIFsxXToKPiAKPiAgICAgRkJJT19XQUlURk9SVlNZTkMgdGFrZXMgdGhlIGNy dGMgYXMgYSBwYXJtZXRlciwgc28gSSdtIG5vdCBzdXJlIHdlIHdhbnQKPiAgICAgdG8gZG8gdGhp cyBmb3IgYWxsIHRoZSBjcnRjcy4gVGhvdWdoIHdoYXQgdGhhdCBjcnRjIG1lYW5zIGZvciBmYiBp cwo+ICAgICByYXRoZXIgcG9vcmx5IGRlZmluZWQuCj4gCj4gRG9uJ3QgdGhpbmsgaXQgdGFrZXMg dGhlIGNydGMgYXMgYSBwYXJhbWV0ZXIgaW4gJ2FyZycuIFdoZW4geW91IGxvb2sgYXQgdGhlCj4g ZXhpc3RpbmcgZmJfaW9jdGwgaW1wbGVtZW50YXRpb25zIGluIHRoZSBkaXJlY3RvcnkgZHJpdmVy cy92aWRlby9mYmRldi8sIHRoZQo+IGFyZ3VtZW50ICdhcmcnIGlzIGVpdGhlciBpZ25vcmVkIG9y IG11c3QgYmUgJzAnLgoKSGF2ZSBhIGxvb2sgYXQgbWF0cm94ZmIuCgo+IAo+IEZ1cnRobW9yZSBt b3N0IGV4aXRpbmcgdXNlcnNwYWNlIGNvZGUganVzdCBwYXNzZXMgdGhlIHZhbHVlICIwIiBhcyB0 aGUKPiBhcmd1bWVudC4gRm9yIGV4YW1wbGUgRGlyZWN0RkI6Cj4gCj4gICAgICBzdGF0aWMgY29u c3QgaW50IHplcm8gPSAwOwo+ICAgICAgWy4uLl0KPiAgICAgIGlmIChpb2N0bCggZGZiX2ZiZGV2 LT5mZCwgRkJJT19XQUlURk9SVlNZTkMsICZ6ZXJvICkpCgpBZ2FpbiB0aGUgbWF0cm94IGRyaXZl ciBpcyBkaWZmZXJlbnQuIEFuZCBsb29rcyBsaWtlIHVuaWNocm9tZSBtaWdodCBoYXZlCmRvbmUg c29tZXRoaW5nIGV2ZW4gbW9yZSBleG90aWMgd2l0aCB0aGUgYXJndW1lbnQuCgpCdXQgSSBkbyBh Z3JlZSB0aGF0IHVzaW5nIHRoaXMgd2l0aCB0aGUga21zIGZiZGV2IGltcGxlbWVudGF0aW9uIGNv dWxkCmJlIHF1aXRlIHByb2JsZW1hdGljIGFzIHlvdSBjYW4ndCBhY3R1YWxseSBrbm93IHdoaWNo IGNydGNzIHRoZQpmYl9oZWxwZXIgaGFzIHBpY2tlZC4KCj4gCj4gSSBzZWUgdHdvIG9wdGlvbnMg aGVyZTogCj4gCj4gMS8gSnVzdCB3YWl0IGZvciB0aGUgZmlyc3QgdnN5bmMgZXZlbnQgb24gdGhl IGZpcnN0IGVuYWJsZWQgY3J0Yy4gVGhpcyBpcwo+ICAgIGEgZ29vZCBhcHByb3hpbWF0aW9uIGZv ciB0aGUgb2xkIGZyYW1lYnVmZmVyIEFQSS4gSXQgaGFzIG5vIGNvbmNlcHQgb2YKPiAgICBtdWx0 aXBsZSBjcnRjcyB3aXRoIGNvbmN1cnJlbmN0bHkgcnVubmluZyBzY2FuIG91dCBwcm9jZXNzZXMu IChNYXliZSBhcGFydAo+ICAgIGZyb20gZXh0cmEgdmVuZG9yIGltcGxlbWVudGF0aW9ucykuIFNv IGlmIHRoZXJlIGFyZSByZWFsbHkgbW9yZSB0aGFuIG9uZSBhY3RpdmUKPiAgICBjcnRjcyBpbiB0 aGUgc3lzdGVtLCBiYWQgbHVjayB3aXRoIGZyYW1lYnVmZmVyIEFQSS4gVGhlcmUgd2lsbCBiZSB0 ZWFyaW5nLgo+ICAgIFVzZXJzcGFjZSBoYXMgdG8gdXNlIHRoZSBuZXcgRFJNL0tNUyBBUEkuCj4g Cj4gMi8gV2FpdCBmb3IgYSBzaW5nbGUgdnN5bmMgZXZlbnQgb24gYWxsIGFjdGl2ZSBjcnRjcyBh cyBWaWxsZSBTeXJqw6Rsw6QgCj4gICAgZGVzY3JpYmVkIGhlcmUgWzJdIGluIHRoZSBvcHRpbWFs IGltcGxlbWVudGF0aW9uLgo+IAo+IEtpbmQgcmVnYXJkcyAvIE1pdCBmcmV1bmRsaWNoZW4gR3LD vMOfZW4KPiAJU3RlZmFuIExlbmdmZWxkCj4gCj4gWzFdIGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL2FyY2hpdmVzL2RyaS1kZXZlbC8yMDE3LUZlYnJ1YXJ5LzEzMjYxNy5odG1sCj4gWzJd IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL2FyY2hpdmVzL2RyaS1kZXZlbC8yMDE3LUZl YnJ1YXJ5LzEzMjgyMC5odG1sCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752083AbdBUKzQ (ORCPT ); Tue, 21 Feb 2017 05:55:16 -0500 Received: from mga07.intel.com ([134.134.136.100]:16047 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbdBUKzG (ORCPT ); Tue, 21 Feb 2017 05:55:06 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,189,1484035200"; d="scan'208";a="826734101" Date: Tue, 21 Feb 2017 12:55:01 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Stefan Lengfeld Cc: Maxime Ripard , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter Subject: Re: [PATCH v3 2/2] drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC Message-ID: <20170221105501.GC31595@intel.com> References: <20170221100059.GD17643@sill.h.stcim.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170221100059.GD17643@sill.h.stcim.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 21, 2017 at 11:00:59AM +0100, Stefan Lengfeld wrote: > Hi Maxime, > > On Wed, Feb 15, 2017 at 05:19:09PM +0100, Maxime Ripard wrote: > > From: Stefan Christ > > > > Maybe change the author here. Only the boilerplate code looks my original > patch. The real code is your work ;-) > > > Implement legacy framebuffer ioctl FBIO_WAITFORVSYNC in the generic > > framebuffer emulation driver. Legacy framebuffer users like non kms/drm > > based OpenGL(ES)/EGL implementations may require the ioctl to > > synchronize drawing or buffer flip for double buffering. It is tested on > > the i.MX6. > > > > Code is based on > > https://github.com/Xilinx/linux-xlnx/blob/master/drivers/gpu/drm/xilinx/xilinx_drm_fb.c#L196 > > > > Signed-off-by: Stefan Christ > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/drm_fb_helper.c | 63 ++++++++++++++++++++++++++++++++++- > > include/drm/drm_fb_helper.h | 12 +++++- > > 2 files changed, 74 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > > index c6de87abaca8..15ee9641c725 100644 > > --- a/drivers/gpu/drm/drm_fb_helper.c > > +++ b/drivers/gpu/drm/drm_fb_helper.c > > @@ -1240,6 +1240,69 @@ int drm_fb_helper_setcmap(struct fb_cmap *cmap, struct fb_info *info) > > EXPORT_SYMBOL(drm_fb_helper_setcmap); > > > > /** > > + * drm_fb_helper_ioctl - legacy ioctl implementation > > + * @info: fbdev registered by the helper > > + * @cmd: ioctl command > > + * @arg: ioctl argument > > + * > > + * A helper to implement the standard fbdev ioctl. Only > > + * FBIO_WAITFORVSYNC is implemented for now. > > + */ > > +int drm_fb_helper_ioctl(struct fb_info *info, unsigned int cmd, > > + unsigned long arg) > > +{ > > + struct drm_fb_helper *fb_helper = info->par; > > + struct drm_device *dev = fb_helper->dev; > > + struct drm_mode_set *mode_set; > > + struct drm_crtc *crtc; > > + u32 karg; > > + int ret = 0; > > + > > + mutex_lock(&dev->mode_config.mutex); > > + if (!drm_fb_helper_is_bound(fb_helper)) { > > + ret = -EBUSY; > > + goto unlock; > > + } > > + > > + switch (cmd) { > > + case FBIO_WAITFORVSYNC: > > + if (get_user(karg, (__u32 __user *)arg)) { > > + ret = -EFAULT; > > + goto unlock; > > + } > > + > > + if (karg >= fb_helper->crtc_count) { > > + ret = -EINVAL; > > + goto unlock; > > + } > > Ville Syrjälä said [1]: > > FBIO_WAITFORVSYNC takes the crtc as a parmeter, so I'm not sure we want > to do this for all the crtcs. Though what that crtc means for fb is > rather poorly defined. > > Don't think it takes the crtc as a parameter in 'arg'. When you look at the > existing fb_ioctl implementations in the directory drivers/video/fbdev/, the > argument 'arg' is either ignored or must be '0'. Have a look at matroxfb. > > Furthmore most exiting userspace code just passes the value "0" as the > argument. For example DirectFB: > > static const int zero = 0; > [...] > if (ioctl( dfb_fbdev->fd, FBIO_WAITFORVSYNC, &zero )) Again the matrox driver is different. And looks like unichrome might have done something even more exotic with the argument. But I do agree that using this with the kms fbdev implementation could be quite problematic as you can't actually know which crtcs the fb_helper has picked. > > I see two options here: > > 1/ Just wait for the first vsync event on the first enabled crtc. This is > a good approximation for the old framebuffer API. It has no concept of > multiple crtcs with concurrenctly running scan out processes. (Maybe apart > from extra vendor implementations). So if there are really more than one active > crtcs in the system, bad luck with framebuffer API. There will be tearing. > Userspace has to use the new DRM/KMS API. > > 2/ Wait for a single vsync event on all active crtcs as Ville Syrjälä > described here [2] in the optimal implementation. > > Kind regards / Mit freundlichen Grüßen > Stefan Lengfeld > > [1] https://lists.freedesktop.org/archives/dri-devel/2017-February/132617.html > [2] https://lists.freedesktop.org/archives/dri-devel/2017-February/132820.html > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC