From: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Shaobo <shaobo-sDh8Nw2yj/+Vc3sceRu5cw@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Potential NULL pointer dereference in drivers/infiniband/core
Date: Tue, 21 Feb 2017 13:59:19 +0200 [thread overview]
Message-ID: <20170221115918.GA3616@yuval-lap> (raw)
In-Reply-To: <7e4ed5f8bdc1578f2459231c78e0d1e9-sDh8Nw2yj/+Vc3sceRu5cw@public.gmane.org>
On Mon, Feb 20, 2017 at 11:23:41PM -0700, Shaobo wrote:
> Dear developers,
>
> My name is Shaobo He and I am a graduate student at University of
> Utah. I am applying a static analysis tool to the Linux device
> drivers and got an error trace of null pointer dereference in
> drivers/infiniband/core starting from function `ucma_accept`: it
> calls `rdma_accept` with the second argument being NULL. In
> `rdma_accept`, `cma_accept_iw` is called with the second argument
> also being NULL. Then in `cma_accept_iw`, `cma_modify_qp_rtr` can
> return 0 if `id_priv->id.qp` is NULL, which can be suggested by an
> if statement in `rdma_accept`. Finally, the second argument
> `conn_param` of `cma_accept_iw` gets dereferenced. As you can see,
> the error trace is only plausible since it depends on certain
> conditions. Therefore, I was wondering if you could confirm it.
>
> Thanks for your time. I am looking forward to your reply.
Suggesting to prepare a patch and ask for review.
I believe the issue will get faster attention this way.
>
> Best,
> Shaobo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-21 11:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 6:23 Potential NULL pointer dereference in drivers/infiniband/core Shaobo
[not found] ` <7e4ed5f8bdc1578f2459231c78e0d1e9-sDh8Nw2yj/+Vc3sceRu5cw@public.gmane.org>
2017-02-21 11:59 ` Yuval Shaia [this message]
[not found] <003d01d28c09$46d1e200$d475a600$@cs.utah.edu>
2017-02-21 18:52 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373AB0E99BB-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-02-21 18:58 ` Steve Wise
2017-02-21 19:05 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373AB0E99ED-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-02-21 19:24 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221115918.GA3616@yuval-lap \
--to=yuval.shaia-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shaobo-sDh8Nw2yj/+Vc3sceRu5cw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.