From: Stephen Hemminger <stephen@networkplumber.org>
To: Kees Cook <keescook@chromium.org>
Cc: Eddie Kovsky <ewk@edkovsky.org>, Jessica Yu <jeyu@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Subject: [kernel-hardening] Re: [PATCH v2 1/3] module: verify address is read-only
Date: Tue, 21 Feb 2017 12:51:23 -0800 [thread overview]
Message-ID: <20170221125123.076be7e9@xeon-e3> (raw)
In-Reply-To: <CAGXu5jKMqPFktwOk_iodie=2J+sT2pHBbTzeuKfDMEYq=dE8Ww@mail.gmail.com>
On Tue, 21 Feb 2017 12:32:16 -0800
Kees Cook <keescook@chromium.org> wrote:
> On Mon, Feb 20, 2017 at 9:14 AM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > On Fri, 17 Feb 2017 21:58:42 -0800
> > "Eddie Kovsky" <ewk@edkovsky.org> wrote:
> >
> >> Implement a mechanism to check if a module's address is in
> >> the rodata or ro_after_init sections. It mimics the exsiting functions
> >> that test if an address is inside a module's text section.
> >>
> >> Signed-off-by: Eddie Kovsky <ewk@edkovsky.org>
> >
> > I don't see the point of this for many of the hyper-v functions.
> > They are only called from a small number of places, and this can be validated
> > by code inspection. Adding this seems just seems to be code bloat to me.
>
> I think it has value in that it effectively blocks any way for
> non-ro_after_init structures from being passed into these functions.
> Since there are so few callers now, it's the perfect place to add
> this.
>
> -Kees
>
Maybe for a more used API, but for such a corner case it is code bloat.
next prev parent reply other threads:[~2017-02-21 20:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 5:58 [kernel-hardening] [PATCH v2 0/3] provide check for ro_after_init memory sections Eddie Kovsky
2017-02-18 5:58 ` [kernel-hardening] [PATCH v2 1/3] module: verify address is read-only Eddie Kovsky
2017-02-20 17:14 ` [kernel-hardening] " Stephen Hemminger
2017-02-21 20:32 ` Kees Cook
2017-02-21 20:51 ` Stephen Hemminger [this message]
2017-02-26 17:42 ` Jessica Yu
2017-02-18 5:58 ` [kernel-hardening] [PATCH v2 2/3] extable: " Eddie Kovsky
2017-02-18 6:33 ` [kernel-hardening] " kbuild test robot
2017-02-18 6:49 ` kbuild test robot
2017-02-18 5:58 ` [kernel-hardening] [PATCH v2 3/3] Make vmbus register arguments read-only Eddie Kovsky
2017-02-18 6:30 ` [kernel-hardening] " kbuild test robot
2017-02-18 8:55 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221125123.076be7e9@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=ewk@edkovsky.org \
--cc=haiyangz@microsoft.com \
--cc=jeyu@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.