From: Dan Carpenter <dan.carpenter@oracle.com>
To: "João Paulo Rechi Vita" <jprvita@gmail.com>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>,
acpi4asus-user <acpi4asus-user@lists.sourceforge.net>
Subject: Re: [bug report] asus-wireless: Toggle airplane mode LED
Date: Tue, 21 Feb 2017 16:27:12 +0300 [thread overview]
Message-ID: <20170221132712.GA5978@mwanda> (raw)
In-Reply-To: <CA+A7VXX-ST1GgeSU6JJ_Wu8BWFqVz66gg6Wshm71agFHbjuVgA@mail.gmail.com>
On Mon, Feb 20, 2017 at 02:22:38PM -0500, João Paulo Rechi Vita wrote:
> Hello Dan,
>
> On 18 February 2017 at 15:30, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > Hello João Paulo Rechi Vita,
> >
> > The patch 2c1a49c96123: "asus-wireless: Toggle airplane mode LED"
> > from Jun 13, 2016, leads to the following static checker warning:
> >
> > drivers/platform/x86/asus-wireless.c:54 asus_wireless_method()
> > error: uninitialized symbol 'ret'.
> >
>
> I believe I have a fix for this, but I'm not able to reproduce this
> message with neither of the following:
>
> make C=2 CHECK="/usr/bin/sparse" drivers/platform/x86/asus-wireless.o
> make C=2 CHECK="../smatch/smatch -p=kernel" drivers/platform/x86/asus-wireless.o
> make C=2 CHECK="scripts/coccicheck" drivers/platform/x86/asus-wireless.o
>
> So I am not able to check the fix. How can I reproduce this?
>
It's some unpublished Smatch stuff... I still have too many false
positives.
regards,
dan carpenter
prev parent reply other threads:[~2017-02-21 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 20:30 [bug report] asus-wireless: Toggle airplane mode LED Dan Carpenter
2017-02-20 14:19 ` João Paulo Rechi Vita
2017-02-20 19:22 ` João Paulo Rechi Vita
2017-02-21 13:27 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221132712.GA5978@mwanda \
--to=dan.carpenter@oracle.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=jprvita@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.