From: Christoph Hellwig <hch@lst.de>
To: David Daney <ddaney@caviumnetworks.com>
Cc: Christoph Hellwig <hch@lst.de>,
George Cherian <gcherian@caviumnetworks.com>,
George Cherian <george.cherian@cavium.com>,
David Daney <david.daney@cavium.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: crypto/cavium MSI-X fixups
Date: Wed, 22 Feb 2017 08:27:52 +0100 [thread overview]
Message-ID: <20170222072752.GA18643@lst.de> (raw)
In-Reply-To: <52c432c9-4dc1-861e-5556-0db2f4a42c98@caviumnetworks.com>
On Tue, Feb 21, 2017 at 09:36:04AM -0800, David Daney wrote:
> With respect to pci_enable_msix(), what do you recommend as a replacement?
pci_alloc_irq_vectors. In fact I have a tree ready for after -rc1
that removes pci_enable_msix() entirely.
> For the crypto/cavium driver, you recommend pci_alloc_irq_vectors(), which
> works well if the required MSI-X indexes are contiguous starting at zero.
> What would be used for a device that has 184 MSI-X, but only a sparse
> subset (fewer than half) of these are required for the driver operation.
> It would waste system resources to use an API that forces us to allocate
> 184 when only 80 are required.
Currently we don't have a good API for that. I've not been through all
users of pci_enable_msix_{range,exact} yet, but so far I've only found
one user not using all vectors from 0 to some limit. Depending how many
such users we have and how they'll look I will have to look into an API
to support that use case.
next prev parent reply other threads:[~2017-02-22 7:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 7:18 crypto/cavium MSI-X fixups Christoph Hellwig
2017-02-15 7:18 ` [PATCH 1/3] crypto: cavium: remove dead MSI-X related define Christoph Hellwig
2017-02-15 7:18 ` [PATCH 2/3] crypto: cavium/cptpf: switch to pci_alloc_irq_vectors Christoph Hellwig
2017-02-15 7:18 ` [PATCH 3/3] crypto: cavium/cptvf: " Christoph Hellwig
2017-02-15 9:17 ` crypto/cavium MSI-X fixups George Cherian
2017-02-19 17:32 ` Christoph Hellwig
2017-02-21 17:36 ` David Daney
2017-02-22 7:27 ` Christoph Hellwig [this message]
2017-02-22 17:45 ` David Daney
2017-02-23 12:16 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170222072752.GA18643@lst.de \
--to=hch@lst.de \
--cc=david.daney@cavium.com \
--cc=ddaney@caviumnetworks.com \
--cc=gcherian@caviumnetworks.com \
--cc=george.cherian@cavium.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.