From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jarno Rajahalme <jarno@ovn.org>
Cc: netdev@vger.kernel.org, fgao@ikuai8.com
Subject: Re: [PATCH net-next 2/2] netfilter: nf_ct_expect: Change __nf_ct_expect_check() return value.
Date: Wed, 22 Feb 2017 10:47:44 +0100 [thread overview]
Message-ID: <20170222094744.GD1581@salvia> (raw)
In-Reply-To: <1487719522-42844-2-git-send-email-jarno@ovn.org>
On Tue, Feb 21, 2017 at 03:25:22PM -0800, Jarno Rajahalme wrote:
> Commit 4dee62b1 ("netfilter: nf_ct_expect: nf_ct_expect_insert()
> returns void") inadvertently changed the successful return value of
> nf_ct_expect_related_report() from 0 to 1 due to
> __nf_ct_expect_check() returning 1 on success. Prevent this
> regression in the future by changing the return value of
> __nf_ct_expect_check() to 0 on success.
Same thing, please Cc netfilter-devel. Thanks.
next prev parent reply other threads:[~2017-02-22 9:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 23:25 [PATCH net-next 1/2] netfilter: nf_ct_expect: nf_ct_expect_related_report(): Return zero on success, Jarno Rajahalme
2017-02-21 23:25 ` [PATCH net-next 2/2] netfilter: nf_ct_expect: Change __nf_ct_expect_check() return value Jarno Rajahalme
2017-02-21 23:45 ` Joe Stringer
2017-02-22 9:47 ` Pablo Neira Ayuso [this message]
2017-02-21 23:41 ` [PATCH net-next 1/2] netfilter: nf_ct_expect: nf_ct_expect_related_report(): Return zero on success, Joe Stringer
2017-02-22 9:47 ` Pablo Neira Ayuso
2017-02-22 10:00 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170222094744.GD1581@salvia \
--to=pablo@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=jarno@ovn.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.