From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932491AbdBVNM0 (ORCPT ); Wed, 22 Feb 2017 08:12:26 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:48406 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932120AbdBVNMT (ORCPT ); Wed, 22 Feb 2017 08:12:19 -0500 Date: Wed, 22 Feb 2017 14:12:18 +0100 From: Peter Zijlstra To: Mike Galbraith Cc: Alex Shi , LKML Subject: Re: 9908859acaa9 cpuidle/menu: add per CPU PM QoS resume latency consideration Message-ID: <20170222131218.GS6515@twins.programming.kicks-ass.net> References: <1487768197.27533.5.camel@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487768197.27533.5.camel@gmx.de> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 22, 2017 at 01:56:37PM +0100, Mike Galbraith wrote: > Hi, > > Do we really need a spinlock for that in the idle loop? Urgh, that's broken on RT, you cannot schedule the idle loop. Also, yeah, reading a s32 should not need no locking, but there's a bunch of pointer chases in between :/ Nasty code that..