From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932575AbdBVNwS (ORCPT ); Wed, 22 Feb 2017 08:52:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48352 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932120AbdBVNwL (ORCPT ); Wed, 22 Feb 2017 08:52:11 -0500 Date: Wed, 22 Feb 2017 14:52:06 +0100 From: Jiri Olsa To: Hari Bathini Cc: ast@fb.com, peterz@infradead.org, lkml , acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, daniel@iogearbox.net, rostedt@goodmis.org, Ananth N Mavinakayanahalli , ebiederm@xmission.com, sargun@sargun.me, Aravinda Prasad , brendan.d.gregg@gmail.com Subject: Re: [PATCH v7 0/8] perf: add support for analyzing events for containers Message-ID: <20170222135206.GB19894@krava> References: <148768564246.30285.16450228018975882950.stgit@hbathini.in.ibm.com> <20170222111117.GA21376@krava> <57d820b3-ce55-bb9c-1c5f-e8b78d7705e5@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57d820b3-ce55-bb9c-1c5f-e8b78d7705e5@linux.vnet.ibm.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 22 Feb 2017 13:52:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 22, 2017 at 06:10:28PM +0530, Hari Bathini wrote: > Hi Jirka, > > > On Wednesday 22 February 2017 04:41 PM, Jiri Olsa wrote: > > On Tue, Feb 21, 2017 at 07:31:11PM +0530, Hari Bathini wrote: > > > Currently, there is no trivial mechanism to analyze events based on > > > containers. perf -G can be used, but it will not filter events for the > > > containers created after perf is invoked, making it difficult to assess/ > > > analyze performance issues of multiple containers at once. > > > > > > This patch-set is aimed at addressing this limitation by introducing a > > > new PERF_RECORD_NAMESPACES event that records namespaces related info. > > > As containers are created with namespaces, the new data can be used to > > > in assessment/analysis of multiple containers. > > > > > > The first patch introduces PERF_RECORD_NAMESPACES in kernel while the > > > second patch makes the corresponding changes in perf tool to read this > > > PERF_RECORD_NAMESPACES events. The third patch demonstrates analysis > > > of containers with this data by adding a cgroup identifier column in > > > perf report, which contains the cgroup namespace's device and inode > > > numbers. This is based on the assumption that each container is created > > > with it's own cgroup namespace. The third patch has scope for improvement > > > based on the conventions a container is attributed with, going forward. > > > > > > Changes from v6: > > > * Updated changelog of patch 1 > > > * Split patch 2 into smaller patches > > > * Updated record and script documenatation > > > * Dropped name field from ns_link_info struct > > what's this version based on? I can't cleanly apply it neither > > on tip's perf/core or master or Arnaldo's perf/core > > That's odd. I based my patches against tip's perf/core > To be precise, the patches apply cleanly on top of commit > 0c8967c9df230d2c4dde6649f410b62e01806c22. got it now, thanks jirka