From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934680AbdBVUwc (ORCPT <rfc822;w@1wt.eu>);
        Wed, 22 Feb 2017 15:52:32 -0500
Received: from mail-wm0-f54.google.com ([74.125.82.54]:36645 "EHLO
        mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934634AbdBVUwG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 22 Feb 2017 15:52:06 -0500
Date: Wed, 22 Feb 2017 20:51:44 +0000
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Thomas Gleixner <tglx@linutronix.de>, Mike Galbraith <efault@gmx.de>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] scheduler changes for v4.11
Message-ID: <20170222205144.GV28416@codeblueprint.co.uk>
References: <20170220101714.GA1847@gmail.com>
 <CA+55aFxtTX7_ob=Ca4iWD-NDQVESRC8m8tWq=HsbUb_akHF79A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFxtTX7_ob=Ca4iWD-NDQVESRC8m8tWq=HsbUb_akHF79A@mail.gmail.com>
User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 22 Feb, at 12:41:01PM, Linus Torvalds wrote:
> Hmm. The scheduler changes seem to show problems with suspend/resume.
> 
> I now get his when suspending:
> 
>   ...
>   Disabling non-boot CPUs ...
>   Cannot set affinity for irq 285
>   smpboot: CPU 1 is now offline
>   ------------[ cut here ]------------
>    WARNING: CPU: 2 PID: 25 at kernel/sched/sched.h:812
> update_load_avg+0x779/0xa70
>   rq->clock_update_flags < RQCF_ACT_SKIP
>   ...
>   Call Trace:
>     update_load_avg+0x779/0xa70
>     set_next_entity+0xd9/0x220
>     pick_next_task_fair+0x88/0x550
>     sched_cpu_dying+0x1cf/0x2a0
>     cpuhp_invoke_callback+0x80/0x3b0
>     take_cpu_down+0x5e/0xa0
>     multi_cpu_stop+0xb6/0xe0
> 
> the issue may have been going on for a while, but the new WARN_ON()
> was added in this merge window.
> 
> (Not sure how consistent this warning is, it definitely doesn't happen
> every time, I've only seen it once)

I think Peter has the fix for this somewhere, but it doesn't look like
it made it to tip/sched/core.

Peter, this is the original patch,

  https://lkml.kernel.org/r/20170202155506.GX6515@twins.programming.kicks-ass.net