From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Teigland <teigland@redhat.com>
Date: Wed, 22 Feb 2017 15:34:00 -0600
Subject: [Cluster-devel] [PATCH v2] fs/dlm: Fix kernel memory disclosure
In-Reply-To: <CAH0z3hNZq1_0mnFcA-4Gooa+QfP+mhgVA_4Yp0M+KSdZvREW6w@mail.gmail.com>
References: <CAH0z3hNZq1_0mnFcA-4Gooa+QfP+mhgVA_4Yp0M+KSdZvREW6w@mail.gmail.com>
Message-ID: <20170222213400.GC14444@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Wed, Feb 22, 2017 at 03:45:34PM +0800, Vlad Tsyrklevich wrote:
> Hello, I wanted to ping the list and see if this could get a review:

now pushed to linux-dlm.git

> > Clear the 'unused' field and the uninitialized padding in 'lksb' to
> > avoid leaking memory to userland in copy_result_to_user().
> >
> > Signed-off-by: Vlad Tsyrklevich <vlad@tsyrklevich.net>
> > ---
> >  fs/dlm/user.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/fs/dlm/user.c b/fs/dlm/user.c
> > index 1ce908c..83ddd47 100644
> > --- a/fs/dlm/user.c
> > +++ b/fs/dlm/user.c
> > @@ -122,6 +122,8 @@ static void compat_input(struct dlm_write_request *kb,
> >  static void compat_output(struct dlm_lock_result *res,
> >                           struct dlm_lock_result32 *res32)
> >  {
> > +       memset(res32, 0, sizeof(*res32));
> > +
> >         res32->version[0] = res->version[0];
> >         res32->version[1] = res->version[1];
> >         res32->version[2] = res->version[2];