Re: [PATCH 1/2] crypto: vmx - Use skcipher for cbc fallback

[Marcelo Cerri <marcelo.cerri@canonical.com>]

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

Hi Hebert,

On Wed, Feb 22, 2017 at 04:18:19PM -0300, Marcelo Cerri wrote:
> Hi Paulo.
> 
> On Wed, Feb 22, 2017 at 03:00:15PM -0300, Paulo Flabiano Smorigo wrote:
> >  
> >  	if (in_interrupt()) {
> > -		ret = crypto_blkcipher_encrypt(&fallback_desc, dst, src,
> > -					       nbytes);
> > +		SKCIPHER_REQUEST_ON_STACK(req, ctx->fallback);
> > +		skcipher_request_set_tfm(req, ctx->fallback);
> > +		skcipher_request_set_callback(req, desc->flags, NULL, NULL);
> > +		skcipher_request_set_crypt(req, src, dst, nbytes, desc->info);
> > +		ret = crypto_skcipher_encrypt(req);
> > +		skcipher_request_zero(req);
> 
> Probably you have to wait for the completion here before proceeding.
> 
> Check Documentation/crypto/api-samples.rst
> 

I noticed you used a similar approach in arch/s390/crypto/aes_s390.c
(commit 64e2680).

How do you ensure the skcipher operation will not be asynchronous? 

-- 
Regards,
Marcelo


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]