From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Pau Espin Pedrol <pespin.shar@gmail.com>,
Andy Shevchenko <andy@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Corentin Chary <corentin.chary@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
acpi4asus-user <acpi4asus-user@lists.sourceforge.net>,
"dvhart@infradead.org" <dvhart@infradead.org>
Subject: Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51
Date: Thu, 23 Feb 2017 00:36:31 -0800 [thread overview]
Message-ID: <20170223083631.GE18639@dtor-ws> (raw)
In-Reply-To: <CAHp75Vem5Rxa+Ms5zop2zCHqExQfv9WPufQ6jPdCBpQQh0AN=w@mail.gmail.com>
On Tue, Feb 21, 2017 at 05:38:59PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 21, 2017 at 3:39 PM, Pau Espin Pedrol <pespin.shar@gmail.com> wrote:
>
> > If we have user space tools supporting and using this type of event,
> > then what about adding them properly with a define + entry in the
> > structure array so that it can be standardized and on top get rid of
> > those kernel message every time I (un)plug the charger? Would that be
> > welcomed? I could send a new patch as specified above, adding the
> > KEY_CHARING_ON/OFF defines + add entries to eeepc_keymap.
>
> Please, do not top posting.
>
> Dmitry, do we have special events for AC (un)plug? What is the best
> approach in your opinion?
Not route them through input as they not input events would be the best.
I'd look into hooking up power_supply class.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2017-02-23 8:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 17:48 [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Pau Espin Pedrol
2017-02-18 16:16 ` Andy Shevchenko
[not found] ` <CAEGpDuaw3uJoxbyOuTWyBodM-JgMd2hSqZUgg_wbyJa+9sJOjw@mail.gmail.com>
2017-02-21 13:39 ` Pau Espin Pedrol
2017-02-21 15:38 ` Andy Shevchenko
2017-02-23 8:36 ` Dmitry Torokhov [this message]
2017-02-24 13:01 ` Pau Espin Pedrol
2017-03-01 23:18 ` Andy Shevchenko
2017-03-07 19:27 ` Dmitry Torokhov
2017-03-07 19:27 ` Dmitry Torokhov
2017-03-13 16:04 ` Andy Shevchenko
2017-03-15 22:15 ` Darren Hart
2017-03-16 23:54 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223083631.GE18639@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pespin.shar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.